cc9a8eb112
The statistics import and restore paths built fake FunctionCallInfos with LOCAL_FCINFO() and InitFunctionCallInfoData(), never calling anything through them. The only data relevantly used was the values carried around as NullableDatum arrays, read back with PG_GETARG_*() macros. import_relation_statistics() and import_attribute_statistics() were passing a set of NullablePointer pointers, leading to more round-trip manipulations with the fake FunctionCallInfos. These are reworked so as the values pushed to pg_class (for relation stats) and pg_statistic (for attribute stats) are passed around in dedicated structures with all the values assigned based on positional indexes (import code cares about less values than the restore code), simplifying their signatures and reducing the number of code lines required to pass the data around. The stats_check_*() functions now take the values and the attribute names rather than a StatsArgInfo with positional indexes, as this code is shared between the stats restore and import. This removes the dependency between the StatsArgInfo bits and the import code. StatsArgInfo is used only for the restore code, for argument mapping. No behavioral change should be introduced in this commit; this is (should be) pure refactoring. Reported-by: Robert Haas <robertmhaas@gmail.com> Author: Corey Huinker <corey.huinker@gmail.com> Author: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CADkLM=eo7MtuCE=YjovW+=ASw1=q39qQ3qarrsw+EKfU901ztA@mail.gmail.com
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.