mirror of
https://github.com/postgres/postgres.git
synced 2026-10-23 13:29:09 +03:00
cc9a8eb112
The statistics import and restore paths built fake FunctionCallInfos with LOCAL_FCINFO() and InitFunctionCallInfoData(), never calling anything through them. The only data relevantly used was the values carried around as NullableDatum arrays, read back with PG_GETARG_*() macros. import_relation_statistics() and import_attribute_statistics() were passing a set of NullablePointer pointers, leading to more round-trip manipulations with the fake FunctionCallInfos. These are reworked so as the values pushed to pg_class (for relation stats) and pg_statistic (for attribute stats) are passed around in dedicated structures with all the values assigned based on positional indexes (import code cares about less values than the restore code), simplifying their signatures and reducing the number of code lines required to pass the data around. The stats_check_*() functions now take the values and the attribute names rather than a StatsArgInfo with positional indexes, as this code is shared between the stats restore and import. This removes the dependency between the StatsArgInfo bits and the import code. StatsArgInfo is used only for the restore code, for argument mapping. No behavioral change should be introduced in this commit; this is (should be) pure refactoring. Reported-by: Robert Haas <robertmhaas@gmail.com> Author: Corey Huinker <corey.huinker@gmail.com> Author: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CADkLM=eo7MtuCE=YjovW+=ASw1=q39qQ3qarrsw+EKfU901ztA@mail.gmail.com
The PostgreSQL contrib tree
---------------------------
This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree. This does not preclude their
usefulness.
User documentation for each module appears in the main SGML
documentation.
When building from the source distribution, these modules are not
built automatically, unless you build the "world" target. You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.
Some directories supply new user-defined functions, operators, or
types. To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command. In a fresh database,
you can simply do
CREATE EXTENSION module_name;
See the PostgreSQL documentation for more information about this
procedure.