lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

getdeps: ensure that INST/lib/*.dll are found in PATH on windows

Browse Source 
Summary:
We were troubleshooting an issue with the eden tests on windows
where the boost dlls where not being found during gtest discovery.

When we compute the environment, we were only including INST/bin in the
PATH on windows.  On Windows, the dlls are searched for in the PATH, and
since boost installs those into its `lib` dir we were missing those.

This diff causes `lib` dirs to get added to PATH on windows in the same
manner that we would add them to `LD_LIBRARY_PATH` on linux.

Reviewed By: pkaush

Differential Revision: D17694542

fbshipit-source-id: 143a907e6d30d8c12360caa43c8d9c26ff8c88c6
This commit is contained in:
Wez Furlong
2019-10-03 12:55:12 -07:00
committed by Facebook Github Bot
parent a66f10d4b9
commit 686f4cdab5
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/fbcode_builder/getdeps/buildopts.py
View File

@@ -186,6 +186,8 @@ class BuildOptions(object):
lib_path = "DYLD_LIBRARY_PATH" lib_path = "DYLD_LIBRARY_PATH"
elif self.is_linux(): elif self.is_linux():
lib_path = "LD_LIBRARY_PATH" lib_path = "LD_LIBRARY_PATH"
elif self.is_windows():
lib_path = "PATH"
else: else:
lib_path = None lib_path = None