From 686f4cdab51c1009eff258378d7595a85a8d975b Mon Sep 17 00:00:00 2001 From: Wez Furlong Date: Thu, 3 Oct 2019 12:55:12 -0700 Subject: [PATCH] getdeps: ensure that INST/lib/*.dll are found in PATH on windows Summary: We were troubleshooting an issue with the eden tests on windows where the boost dlls where not being found during gtest discovery. When we compute the environment, we were only including INST/bin in the PATH on windows. On Windows, the dlls are searched for in the PATH, and since boost installs those into its `lib` dir we were missing those. This diff causes `lib` dirs to get added to PATH on windows in the same manner that we would add them to `LD_LIBRARY_PATH` on linux. Reviewed By: pkaush Differential Revision: D17694542 fbshipit-source-id: 143a907e6d30d8c12360caa43c8d9c26ff8c88c6 --- build/fbcode_builder/getdeps/buildopts.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build/fbcode_builder/getdeps/buildopts.py b/build/fbcode_builder/getdeps/buildopts.py index 910361ce7..5c5e29857 100644 --- a/build/fbcode_builder/getdeps/buildopts.py +++ b/build/fbcode_builder/getdeps/buildopts.py @@ -186,6 +186,8 @@ class BuildOptions(object): lib_path = "DYLD_LIBRARY_PATH" elif self.is_linux(): lib_path = "LD_LIBRARY_PATH" + elif self.is_windows(): + lib_path = "PATH" else: lib_path = None