lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2026-10-24 01:33:54 +03:00
Code Activity

remove HttpTxn::onPushedTransaction

Browse Source 
Summary: We're currently deprecating PUSH_PROMISE support in http/2 and http/3 for proxygen/lib – this diff is focused on the removal of `HttpTxn::onPushedTransaction`

Reviewed By: kwaugh

Differential Revision: D121228773

fbshipit-source-id: 27bda0777353587964a369333d54bc57fa93b82b
This commit is contained in:
Hani Damlaj
2026-09-23 10:37:04 -07:00
committed by meta-codesync[bot]
parent e9abff668b
commit 12a67fb52f
2 changed files with 0 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
proxygen/lib/http/session/HTTPTransaction.cpp
View File

@@ -1704,23 +1704,6 @@ void HTTPTransaction::checkCreateDeferredIngress() {
}
}
bool HTTPTransaction::onPushedTransaction(HTTPTransaction* pushTxn) {
DestructorGuard g(this);
INVARIANT_RETURN(*pushTxn->assocStreamId_ == id_, false);
if (!handler_) {
VLOG(4) << "Cannot add a pushed txn to an unhandled txn";
return false;
}
refreshTimeout();
handler_->onPushedTransaction(pushTxn);
if (!pushTxn->getHandler()) {
VLOG(4) << "Failed to create a handler for push transaction";
return false;
}
pushedTransactions_.insert(pushTxn->getID());
return true;
}
void HTTPTransaction::setIdleTimeout(std::chrono::milliseconds idleTimeout) {
idleTimeout_ = idleTimeout;
VLOG(4) << "HTTPTransaction: idle timeout is set to "

8
proxygen/lib/http/session/HTTPTransaction.h
View File

@@ -1406,14 +1406,6 @@ class HTTPTransaction
return txn;
}
/**
* Invoked by the session (upstream only) when a new pushed transaction
* arrives. The txn's handler will be notified and is responsible for
* installing a handler. If no handler is installed in the callback,
* the pushed transaction will be aborted.
*/
bool onPushedTransaction(HTTPTransaction* txn);
/**
* True if this transaction is a server push transaction
*/