diff --git a/proxygen/lib/http/session/HTTPTransaction.cpp b/proxygen/lib/http/session/HTTPTransaction.cpp index 542310d7b..17b5418c7 100644 --- a/proxygen/lib/http/session/HTTPTransaction.cpp +++ b/proxygen/lib/http/session/HTTPTransaction.cpp @@ -1704,23 +1704,6 @@ void HTTPTransaction::checkCreateDeferredIngress() { } } -bool HTTPTransaction::onPushedTransaction(HTTPTransaction* pushTxn) { - DestructorGuard g(this); - INVARIANT_RETURN(*pushTxn->assocStreamId_ == id_, false); - if (!handler_) { - VLOG(4) << "Cannot add a pushed txn to an unhandled txn"; - return false; - } - refreshTimeout(); - handler_->onPushedTransaction(pushTxn); - if (!pushTxn->getHandler()) { - VLOG(4) << "Failed to create a handler for push transaction"; - return false; - } - pushedTransactions_.insert(pushTxn->getID()); - return true; -} - void HTTPTransaction::setIdleTimeout(std::chrono::milliseconds idleTimeout) { idleTimeout_ = idleTimeout; VLOG(4) << "HTTPTransaction: idle timeout is set to " diff --git a/proxygen/lib/http/session/HTTPTransaction.h b/proxygen/lib/http/session/HTTPTransaction.h index ffb19b699..b54e31ebb 100644 --- a/proxygen/lib/http/session/HTTPTransaction.h +++ b/proxygen/lib/http/session/HTTPTransaction.h @@ -1406,14 +1406,6 @@ class HTTPTransaction return txn; } - /** - * Invoked by the session (upstream only) when a new pushed transaction - * arrives. The txn's handler will be notified and is responsible for - * installing a handler. If no handler is installed in the callback, - * the pushed transaction will be aborted. - */ - bool onPushedTransaction(HTTPTransaction* txn); - /** * True if this transaction is a server push transaction */