Commit Graph
28664 Commits
Author SHA1 Message Date
Jim Meyering e9ba42e9bf chroot: fix typo in preceding change: didn't compile
* src/chroot.c (usage): Add backslashes.
2017-08-11 17:48:47 -07:00
Jim Meyering 9bf4361f4d doc: correct technicality in chroot's --help output
* src/chroot.c (usage): Use correct quoting in descriptive diagnostic.
We would run `"$SHELL" -i`, not `${SHELL} -i`.
2017-08-10 09:18:58 -07:00
Assaf Gordon 8e2929a29b doc: fix join example
* doc/coreutils.texi (join invocation): Fix incorrect output in example.
Reported by Phlosioneer in https://bugs.gnu.org/28014 .
2017-08-08 22:04:57 -06:00
Paul Eggert fd7ac4402b build: update gnulib submodule to latest 2017-08-03 16:34:17 -07:00
Paul Eggert b6ab084421 copy: more-accurate warning about destruction
* src/copy.c (copy_internal):
* tests/cp/backup-is-src.sh, tests/mv/backup-is-src.sh:
Say "might destroy", not "would destroy".
2017-08-03 13:46:36 -07:00
Pádraig Brady 81a05b32f7 maint: avoid a syntax-check failure
* src/shred.c (wipename): As per the comment, the arguments
to error() are sufficiently quoted, so split the call over
multiple lines to avoid the syntax-check.
2017-08-02 20:21:20 -07:00
Paul Eggert 1af3fb93f8 build: update gnulib submodule to latest 2017-08-02 11:14:21 -07:00
Paul Eggert a04039284c copy: go back to failing 'cp --backup a~ a'
Suggested by Kamil Dudka in:
http://lists.gnu.org/archive/html/coreutils/2017-07/msg00072.html
* NEWS: Document the changed nature of the fix.
* doc/coreutils.texi, tests/cp/backup-is-src.sh:
* tests/mv/backup-is-src.sh: Revert previous change.
* src/copy.c (source_is_dst_backup): New function.
(copy_internal): Use it.  Fail instead of falling back on numbered
backups when it looks like the backup will overwrite the source.
Although this reintroduces a race, it's more compatible with
previous behavior.
2017-08-01 13:18:45 -07:00
Paul Eggert e01bb64aeb copy: sanity-check --suffix
* src/cp.c, src/install.c, src/ln.c, src/mv.c (main):
Use set_simple_backup_suffix, to sanity-check the user-supplied
backup suffix.
2017-07-30 17:18:31 -07:00
Paul Eggert 0d74ac470f copy: make backup files more reliably
* NEWS, doc/coreutils.texi (Backup options): Document the change.
* bootstrap.conf (gnulib_modules): Add backup-rename.
* src/copy.c (copy_internal): Silently switch to numbered backups
if a simple backup might lose data.  Use backup_file_rename
to avoid races with numbered backups.
* tests/cp/backup-is-src.sh, tests/mv/backup-is-src.sh:
Adjust to match new behavior.
2017-07-30 17:18:31 -07:00
Paul Eggert 2ae1460dad shred: avoid rename race
Use renameat2 to avoid a rename race condition, on recent-enough
GNU/Linux.
* bootstrap.conf (gnulib_modules): Add renameat2.
* src/shred.c: Include renameat2.h.
(wipename): Use renameat2 instead of rename.
2017-07-30 17:18:31 -07:00
Paul Eggert ac6956bbce build: update gnulib submodule to latest 2017-07-30 17:18:31 -07:00
Jim Meyering c8ee5f19e8 maint: fix grammar in a shred.c comment
* src/shred.c: Remove spurious "to" in an old comment.
2017-07-24 17:55:26 -07:00
Pádraig Brady 5744964496 maint: fix recent syntax-check failures
* .gitignore: Add /lib/utime.h from the recent gnulib update.
* src/nproc.c (usage): Adjust spacing to placate help2man.
2017-07-23 12:32:29 -07:00
Pádraig Brady 79c8041a84 shred: remove redundant zeroing of freed memory
* src/shred.c (dopass): shred used to read the input file,
and so needed to ensure internal memory was cleared.
This is no longer the case since SH-UTILS-1_16f-260-gf381610
so avoid this redundant clearing.
(do_wipefd): Likewise.
* NEWS: Remove the recent mention of this issue.
2017-07-23 12:26:22 -07:00
Pádraig Brady 8b1c6eebac maint: resync with blake2 upstream
* src/blake2/blake2-impl.h: Don't use the equivalent explicit_bzero().
2017-07-23 12:25:40 -07:00
Pádraig Brady 388e150792 tests: avoid a false failure on AIX
* tests/misc/sync.sh: Normalize the error messages
when syncing a non read/write directory, as AIX
gives the "Is a directory" error.
Also ensure that sync(1) returns an error for this
case on all systems.
2017-07-23 12:23:31 -07:00
Paul Eggert 73d55732df shred: use explicit_bzero
* NEWS: Document this.
* bootstrap.conf (gnulib_modules): Add explicit_bzero.
* gl/lib/randint.c (randint_free):
* gl/lib/randread.c (randread_free):
* src/blake2/blake2-impl.h (secure_zero_memory):
* src/shred.c (dopass, do_wipefd):
Prefer explicit_bzero to memset when erasing secrets.
2017-07-20 14:02:47 -07:00
Paul Eggert b05d02318c build: update gnulib submodule to latest 2017-07-20 14:02:46 -07:00
Andreas Schwab 545f181f4e nproc: fix indentation of usage output
* src/nproc.c (usage): Align output.
2017-07-10 09:40:03 -07:00
Jim Meyering 83ed661947 groups: do not exit early
Most programs take care to operate on all command-line-specified
operands before exiting.  That is an important feature that allows
to identify all problems with the first run.  However, groups would
exit upon the first problematic user name.
Bug introduced via commit v6.10-56-g167b8025ac.
* src/groups.c (main): Do not exit immediately upon error.
* tests/misc/groups-process-all.sh: New file. Test for this.
* tests/local.mk (all_tests): Add it.
* NEWS (Bug fixes): Mention this.
2017-07-10 10:17:57 +02:00
Jim Meyering ed57568ea5 tests: groups-dash.sh: avoid false failure
* tests/misc/groups-dash.sh: Avoid false failure on a system for which
"none" is a valid user name.  The first invocation would succeed, and
the second would fail with "groups: ‘--’: no such user".
Use a user name that cannot exist.
2017-07-08 18:41:16 +02:00
Jim Meyering df2c30dca6 doc: tweak wording
* NEWS (Bug fixes): Tweak wording of the mv/cp-vs-symlink-ownership
entry and the one about df.
2017-07-08 18:41:16 +02:00
Assaf Gordon a9f2be5bfe expr: add multibyte support
Discussed in https://bugs.gnu.org/26779 .

* NEWS: Mention the improvement.
* bootstrap.conf: Add gnulib modules mbslen,mbschr.
* src/expr.c (mbs_logical_substr): New function to return a substring
based on logical character positions (instead of bytes).
(mbs_logical_cspn): Similar to strcspn/mbscspn, but returns number of
logical characters instead of byte offset.
(mbs_offset_to_chars): New function to return number of logical
characters fitting in a given byte offset.
(docolon): Report matched logical characters instead of bytes.
(eval6): For length/substr/index operations, use logical characters
instead of bytes by calling the above new functions.
* tests/misc/expr.pl: Repeat all tests with non-C locale to detect any
regressions.
* tests/misc/expr-multibyte.pl: New tests with multibyte input.
* tests/local.mk: Add new test file.
2017-06-28 01:23:52 +00:00
Jim Meyering e13fe20049 maint: avoid spurious "make distcheck" failure
When the generated file, doc/constants.texi, happens to be older than
doc/coreutils.info, it will not be updated until/unless its generated
contents change.  This is due to way that rule is careful to update
the file, to avoid provoking a pointless rerunning of makeinfo.

Note that this does not happen when one first runs "make distclean",
as recommended in README-release.  However, I sometimes run it as
a more-rigorous "make check", and shouldn't have to manually run
"make distclean" first, in that case.

Before this change, one could reproduce the failure by running
`touch -dyesterday doc/constants.texi && make distcheck`.  It would
fail with "makeinfo: could not open ../../doc/coreutils.info-t
for writing: Permission denied"
* Makefile.am (dist-hook): Touch the two generated files, so that
they cannot be out of date wrt doc/coreutils.texi.
2017-06-20 16:01:39 -07:00
Pádraig Brady 1379bdc65b maint: use C99 for loop initial declarations where possible
This results in a net reduction of about 120 lines.
2017-06-17 15:51:59 -07:00
Pádraig Brady 18f6b22fe1 tail: only use inotify with regular files
* src/tail.c (any_non_regular): A new function to check passed files.
(main): Use the above to skip inotify if any non regular files passed
like /dev/tty or /dev/ttyUSB0 etc.
* tests/tail-2/inotify-only-regular.sh: A new test.
* tests/local.mk: Reference the new test.
* NEWS: Mention the bug fix.
Fixes http://bugs.gnu.org/21265 and http://bugs.gnu.org/27368
2017-06-17 14:50:04 -07:00
Pádraig Brady aab875a40b tail: with -f don't warn if doing a blocking read of a tty
* src/tail.c: (main): Only issue the warning about -f being
ineffective when we're not going into simple blocking mode.
* tests/tail-2/follow-stdin.sh: Ensure the warning is output correctly.
Fixes http://bugs.gnu.org/27368
2017-06-17 14:50:00 -07:00
Pádraig Brady ce0415fda1 tail: exit promptly when output no longer writable
This will support use cases like:

  tail -f file.log | grep -q trigger &&
  process_immediately

* src/tail.c (check_output_alive): A new function that
uses select on fifos or pipes to detect if they're broken.
(tail_forever): Call check_output_alive() periodically.
(tail_forever_inotify): Merge the select() call from
check_output_alive() into the select() originally present
for the --pid case, and adjust accordingly.
* tests/tail-2/pipe-f.sh: Add test cases.
* NEWS: Mention the improvement.
2017-06-11 15:05:14 -07:00
Jim Meyering 28042c4ff5 maint: update to work with GCC7's -Werror=implicit-fallthrough=5
* src/system.h (FALLTHROUGH): Define.
* src/cp.c (main): Use new FALLTHROUGH macro in place of comments.
* src/basename.c (main): Likewise.
* src/dircolors.c (append_quoted): Likewise.
* src/echo.c (main): Likewise.
* src/fold.c (main): Likewise.
* src/join.c (main): Likewise.
* src/kill.c (main): Likewise.
* src/ls.c (get_funky_string, gobble_file): Likewise.
* src/sort.c (parse_field_count, main): Likewise.
* src/stat.c (print_it): Likewise.
* src/tail.c (parse_obsolete_option): Likewise.
* src/test.c (posixtest): Likewise.
* src/wc.c (wc): Likewise.
* src/who.c (main): Likewise.
2017-06-10 19:40:49 -07:00
Pádraig Brady ba16bdd890 tail: with --pid, ensure all inotify events are processed
* NEWS: Mention the bug fix.
* src/tail.c (tail_forever_inotify): With --pid, avoid waiting
for new events if there are still events to process.
* tests/tail-2/inotify-dir-recreate.sh: Adjust to trigger.
2017-06-07 10:09:46 -07:00
Pádraig Brady fd41e49973 tests: fix issues with recently added tail test
* tests/tail-2/inotify-dir-recreate.sh: Skip when
inotify is not usable.  Also remove a bash specific &> construct.
2017-06-07 00:03:37 -07:00
Pádraig Brady f1de9740e6 copy: don't fail when unable to chown symlinks
* src/copy.c (copy_internal): Honor the x->require_preserve flag
for symlinks as we do for ordinary files, so we don't exit with
failure upon failure to chown a symbolic link.
* NEWS: Mention the bug fix.
2017-06-02 21:54:03 -07:00
Sebastian Kisela 6ebaf81950 doc: mention setpriv --no-new-privs feature in runcon info
* doc/coreutils.texi (runcon invocation): Mention setpriv usage.
Discussed at https://bugzilla.redhat.com/1360903
2017-05-29 12:42:00 -07:00
Pádraig Brady 62c6f1fc78 mv: distinguish copy and rename operations with --verbose
* src/copy.c (copy_internal): In x->move_mode distinguish
whether we're copying, creating directory, or renaming.
* tests/mv/backup-dir.sh: Adjust to new output.
* tests/mv/mv-n.sh: Likewise.
* tests/mv/mv-special-1.sh: Likewise.
* NEWS: Mention the improvement.
Fixes http://bugs.gnu.org/26971
2017-05-18 02:08:42 +01:00
Prateek saxena 82911c51ae uptime: remove inconsistent AM/PM from current time
* src/uptime.c (main): 00-23 was always used for the hour component
of the current time, so remove the AM/PM output (which was only
present in some locales anyway).  Also add seconds to the time
to be more consistent with the usual procps-ng uptime implementation
on GNU/Linux.
* NEWS: Mention the fix.
Fixes http://bugs.gnu.org/26783
2017-05-11 12:54:29 +01:00
Pádraig Brady 42192c5177 maint: fix various typos in recent commits
* NEWS: Grammar fixes.
* HACKING: Likewise.
2017-05-03 18:23:17 -07:00
Jaak Ristioja b359661725 doc: Fixed typo in timeout man page
* man/timeout.x: Correct spelling of "currently".
Fixes http://bugs.gnu.org/26762
2017-05-03 18:17:48 -07:00
Pádraig Brady d91e912343 doc: update the instructions for generating a coverage report
* HACKING: Change from explicit instructions to using gnulib
provided coverage testing targets.  Also include instructions
for adding root only tests to the report.
Fixes http://bugs.gnu.org/26709
2017-04-29 20:56:10 -07:00
Paul Eggert 7ea15a57c7 dd: simplify translator’s jobs
* src/dd.c (print_xfer_stats): Format the SI units directly,
without translating them, to simplify the translators’ jobs.
See Bug#26621.
2017-04-27 14:49:43 -07:00
Pádraig Brady 9287ef2b17 date,touch: test and document large TZ security issue
Add a test for CVE-2017-7476 which was fixed in gnulib at:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=94e01571

* tests/misc/date-tz.sh: Add a new test which overwrites enough
of the heap to trigger a segfault, even without ASAN enabled.
* tests/local.mk: Reference the new test.
* NEWS: Mention the bug fix.
2017-04-26 21:49:12 -07:00
Pádraig Brady 5d4be52a98 build: update gnulib submodule to latest
* .gitignore: Add new entry as indicated by `make syntax-check`.
2017-04-26 21:49:06 -07:00
Paul Eggert d1f5616b2d dd: status=progress outputs "6 s", not "6.00001 s"
Problem reported by Benno Schulenberg (Bug#26621).
* NEWS: Document this.
* src/dd.c (print_xfer_stats): With status=progress,
format times with %.0f rather than %g.  Improve
translator comments.
2017-04-24 00:32:15 -07:00
Paul Eggert ed0b8f195a build: update gnulib submodule to latest 2017-04-22 15:18:51 -07:00
Paul Eggert 28b677c014 maint: remove unused functions and constants
These were found by clang.
* gl/lib/rand-isaac.c (min):
* gl/lib/randint.c (shift_right):
* src/md5sum.c (algorithm):
Remove; unused.
2017-04-22 02:47:21 -07:00
Paul Eggert e97ee26c88 date: adjust to gnulib parse-datetime changes
* doc/coreutils.texi (Options for date): Capitalize a sentence.
* tests/misc/date-debug.sh: Adjust --debug output to match
recent changes to Gnulib’s parse-datetime module.
2017-04-22 02:47:21 -07:00
Paul Eggert a750b6cfc3 build: update gnulib submodule to latest
* gl/modules/tempname.diff: Update to match current Gnulib.
2017-04-22 02:47:20 -07:00
Bogdan Drozdowski f4570a9ed6 shred: fix invalid pattern generation for certain sizes
* src/shred.c (fillpattern): Fix the "off by one" issue when
testing whether we have enough space to copy the already
written portion of the buffer to the remainder of the buffer.
Specifically for buffer sizes that are (3*(2^x))+1, i.e. 7,13,...
we both use an uninitialized byte and invoke undefined
behavior in memcpy() operation on overlapping memory regions.
* tests/misc/shred-passes.sh: Add an invocation that will
trigger either valgrind UMR, or ASAN like:
  ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges
  #1 0x403065 in fillpattern src/shred.c:293
A direct test is awkward due to the random writes surrounding
the problematic pattern writes.
Fixes http://bugs.gnu.org/26545
2017-04-17 19:44:30 -07:00
Bo Rydberg 8d34b455f8 doc: fix awk example for getting penultimate field
* doc/coreutils.texi (cut invocation): Add required brackets.
Fixes http://bugs.gnu.org/26519
2017-04-16 19:10:17 -07:00
Sebastian Kisela ba5fe2d4b8 tail: revert to polling if a followed directory is replaced
* src/tail.c (tail_forever_inotify): Add the IN_DELETE_SELF flag when
creating watch for the parent directory.  After the parent directory
is removed, an event is caught and then we switch from inotify to
polling mode.  Till now, inotify has always frozen because it waited for
an event from a watched dir, which has been already deleted and was not
added again.
* tests/tail-2/inotify-dir-recreate.sh: Add a test case.
* tests/local.mk: Reference the new test.
* NEWS: Mention the bug fix.
Fixes http://bugs.gnu.org/26363
Reported at https://bugzilla.redhat.com/1283760
2017-04-05 17:45:17 -07:00