shred: remove redundant zeroing of freed memory

* src/shred.c (dopass): shred used to read the input file,
and so needed to ensure internal memory was cleared.
This is no longer the case since SH-UTILS-1_16f-260-gf381610
so avoid this redundant clearing.
(do_wipefd): Likewise.
* NEWS: Remove the recent mention of this issue.
This commit is contained in:
Pádraig Brady committed 2017-07-23 12:26:22 -07:00
1 parent 8b1c6eebac
commit 79c8041a84
2 files changed
-6

No files matched your search

-4
View File
@@ -25,10 +25,6 @@ GNU coreutils NEWS -*- outline -*-
Now, it prints a diagnostic or a line to stdout for each argument.
[bug introduced in the bourne-shell-to-C rewrite for coreutils-6.11]
shred now erases buffers containing secrets via the explicit_bzero
function, which should be more reliable.
[potential bug has always been present in 'shred']
split no longer exits when invocations of a --filter return EPIPE.
[bug introduced in coreutils-8.26]
-2
View File
@@ -653,7 +653,6 @@ dopass (int fd, struct stat const *st, char const *qname, off_t *sizep,
}
free_pattern_mem:
explicit_bzero (pbuf, FILLPATTERN_SIZE);
free (fill_pattern_mem);
return other_error ? -1 : write_error;
@@ -987,7 +986,6 @@ do_wipefd (int fd, char const *qname, struct randint_source *s,
}
wipefd_out:
explicit_bzero (passarray, flags->n_iterations * sizeof (int));
free (passarray);
return ok;
}