cde33148c9
When a table's only GENERATED ALWAYS AS IDENTITY column had been dropped, pg_dump --inserts and --column-inserts could still emit OVERRIDING SYSTEM VALUE in INSERT statements. This clause has no effect when restoring into PostgreSQL but introduces unnecessary differences between dumps of otherwise equivalent tables. ALTER TABLE ... DROP COLUMN leaves pg_attribute.attidentity unchanged. getTableAttrs() used this field to set needs_override without checking attisdropped, so a dropped identity column could trigger the clause even when no remaining column required it. Ignore dropped columns when determining whether to emit the clause, so that the output reflects only the table's remaining columns. Apply to master only, since the unnecessary clause does not affect restoration into PostgreSQL and does not warrant backpatching. Author: William Bernbaum <wbernbaum@dwdev.com> Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: solai v <solai.cdac@gmail.com> Reviewed-by: shihao zhong <zhong950419@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/PH0PR18MB44430C10F7431F8D163CDAFFA6202@PH0PR18MB4443.namprd18.prod.outlook.com
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.