database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Harmonize function parameter names for Postgres 19.

Browse Source 
Make sure that function declarations use names that exactly match the
corresponding names from function definitions in a few places.  Most of
these inconsistencies were introduced during Postgres 19 development.

This commit was written with help from clang-tidy, by mechanically
applying the same rules as similar clean-up commits (the earliest such
commit was commit 035ce1fe).
This commit is contained in:
Peter Geoghegan
2026-04-22 12:47:19 -04:00
parent a50777680f
commit d14f69a32a
18 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/jsonb_plperl/jsonb_plperl.c
View File

@@ -13,7 +13,7 @@ PG_MODULE_MAGIC_EXT(
);
static SV *Jsonb_to_SV(JsonbContainer *jsonb);
static void SV_to_JsonbValue(SV *obj, JsonbInState *ps, bool is_elem);
static void SV_to_JsonbValue(SV *in, JsonbInState *jsonb_state, bool is_elem);
static SV *

2
contrib/sepgsql/sepgsql.h
View File

@@ -274,7 +274,7 @@ extern void sepgsql_object_relabel(const ObjectAddress *object,
/*
* dml.c
*/
extern bool sepgsql_dml_privileges(List *rangeTabls, List *rteperminfos,
extern bool sepgsql_dml_privileges(List *rangeTbls, List *rteperminfos,
bool abort_on_violation);
/*

2
src/backend/access/heap/pruneheap.c
View File

@@ -205,7 +205,7 @@ static void prune_freeze_setup(PruneFreezeParams *params,
PruneState *prstate);
static void heap_page_fix_vm_corruption(PruneState *prstate,
OffsetNumber offnum,
VMCorruptionType ctype);
VMCorruptionType corruption_type);
static void prune_freeze_fast_path(PruneState *prstate,
PruneFreezeResult *presult);
static void prune_freeze_plan(PruneState *prstate,

2
src/backend/commands/propgraphcmds.c
View File

@@ -73,7 +73,7 @@ struct element_info
};
static ArrayType *propgraph_element_get_key(ParseState *pstate, const List *keycols, Relation element_rel,
static ArrayType *propgraph_element_get_key(ParseState *pstate, const List *key_clause, Relation element_rel,
const char *aliasname, int location);
static void propgraph_edge_get_ref_keys(ParseState *pstate, const List *keycols, const List *refcols,
Relation edge_rel, Relation ref_rel,

2
src/backend/commands/repack.c
View File

@@ -180,7 +180,7 @@ static void adjust_toast_pointers(Relation relation, TupleTableSlot *dest,
TupleTableSlot *src);
static bool find_target_tuple(Relation rel, ChangeContext *chgcxt,
TupleTableSlot *locator,
TupleTableSlot *received);
TupleTableSlot *retrieved);
static void process_concurrent_changes(XLogRecPtr end_of_wal,
ChangeContext *chgcxt,
bool done);

2
src/backend/parser/gram.y
View File

@@ -184,7 +184,7 @@ static void doNegateFloat(Float *v);
static Node *makeAndExpr(Node *lexpr, Node *rexpr, int location);
static Node *makeOrExpr(Node *lexpr, Node *rexpr, int location);
static Node *makeNotExpr(Node *expr, int location);
static Node *makeAArrayExpr(List *elements, int location, int end_location);
static Node *makeAArrayExpr(List *elements, int location, int location_end);
static Node *makeSQLValueFunction(SQLValueFunctionOp op, int32 typmod,
int location);
static Node *makeXmlExpr(XmlExprOp op, char *name, List *named_args,

2
src/backend/replication/logical/conflict.c
View File

@@ -47,9 +47,9 @@ static void errdetail_apply_conflict(EState *estate,
TimestampTz localts, StringInfo err_msg);
static void get_tuple_desc(EState *estate, ResultRelInfo *relinfo,
ConflictType type, char **key_desc,
TupleTableSlot *searchslot, char **search_desc,
TupleTableSlot *localslot, char **local_desc,
TupleTableSlot *remoteslot, char **remote_desc,
TupleTableSlot *searchslot, char **search_desc,
Oid indexoid);
static char *build_index_value_desc(EState *estate, Relation localrel,
TupleTableSlot *slot, Oid indexoid);

2
src/backend/replication/pgrepack/pgrepack.c
View File

@@ -27,7 +27,7 @@ static void repack_begin_txn(LogicalDecodingContext *ctx,
static void repack_commit_txn(LogicalDecodingContext *ctx,
ReorderBufferTXN *txn, XLogRecPtr commit_lsn);
static void repack_process_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
Relation rel, ReorderBufferChange *change);
Relation relation, ReorderBufferChange *change);
static void repack_store_change(LogicalDecodingContext *ctx, Relation relation,
ConcurrentChangeKind kind, HeapTuple tuple);

2
src/backend/rewrite/rewriteGraphTable.c
View File

@@ -92,7 +92,7 @@ struct path_element
static Node *replace_property_refs(Oid propgraphid, Node *node, const List *mappings);
static List *build_edge_vertex_link_quals(HeapTuple edgetup, int edgerti, int refrti, Oid refid, AttrNumber catalog_key_attnum, AttrNumber catalog_ref_attnum, AttrNumber catalog_eqop_attnum);
static List *generate_queries_for_path_pattern(RangeTblEntry *rte, List *path_pattern);
static Query *generate_query_for_graph_path(RangeTblEntry *rte, List *path);
static Query *generate_query_for_graph_path(RangeTblEntry *rte, List *graph_path);
static Node *generate_setop_from_pathqueries(List *pathqueries, List **rtable, List **targetlist);
static List *generate_queries_for_path_pattern_recurse(RangeTblEntry *rte, List *pathqueries, List *cur_path, List *path_elem_lists, int elempos);
static Query *generate_query_for_empty_path_pattern(RangeTblEntry *rte);

2
src/backend/storage/buffer/bufmgr.c
View File

@@ -685,7 +685,7 @@ static inline int BufferLockDisownInternal(Buffer buffer, BufferDesc *buf_hdr);
static inline bool BufferLockAttempt(BufferDesc *buf_hdr, BufferLockMode mode);
static void BufferLockQueueSelf(BufferDesc *buf_hdr, BufferLockMode mode);
static void BufferLockDequeueSelf(BufferDesc *buf_hdr);
static void BufferLockWakeup(BufferDesc *buf_hdr, bool unlocked);
static void BufferLockWakeup(BufferDesc *buf_hdr, bool wake_exclusive);
static void BufferLockProcessRelease(BufferDesc *buf_hdr, BufferLockMode mode, uint64 lockstate);
static inline uint64 BufferLockReleaseSub(BufferLockMode mode);

2
src/bin/pg_upgrade/multixact_read_v18.h
View File

@@ -32,6 +32,6 @@ extern OldMultiXactReader *AllocOldMultiXactRead(char *pgdata,
extern bool GetOldMultiXactIdSingleMember(OldMultiXactReader *state,
MultiXactId multi,
MultiXactMember *member);
extern void FreeOldMultiXactReader(OldMultiXactReader *reader);
extern void FreeOldMultiXactReader(OldMultiXactReader *state);
#endif /* MULTIXACT_READ_V18_H */

2
src/include/commands/repack.h
View File

@@ -40,7 +40,7 @@ extern PGDLLIMPORT volatile sig_atomic_t RepackMessagePending;
extern void ExecRepack(ParseState *pstate, RepackStmt *stmt, bool isTopLevel);
extern void cluster_rel(RepackCommand command, Relation OldHeap, Oid indexOid,
extern void cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
ClusterParams *params, bool isTopLevel);
extern void check_index_is_clusterable(Relation OldHeap, Oid indexOid,
LOCKMODE lockmode);

2
src/include/executor/executor.h
View File

@@ -758,7 +758,7 @@ extern void ExecCloseIndices(ResultRelInfo *resultRelInfo);
#define EIIT_NO_DUPE_ERROR (1<<1)
#define EIIT_ONLY_SUMMARIZING (1<<2)
extern List *ExecInsertIndexTuples(ResultRelInfo *resultRelInfo, EState *estate,
uint32 options, TupleTableSlot *slot,
uint32 flags, TupleTableSlot *slot,
List *arbiterIndexes,
bool *specConflict);
extern bool ExecCheckIndexConstraints(ResultRelInfo *resultRelInfo,

2
src/include/postmaster/datachecksum_state.h
View File

@@ -37,7 +37,7 @@ typedef enum
} DataChecksumsWorkerResult;
/* Prototypes for data checksum state manipulation */
bool AbsorbDataChecksumsBarrier(ProcSignalBarrierType target_state);
bool AbsorbDataChecksumsBarrier(ProcSignalBarrierType barrier);
void EmitAndWaitDataChecksumsBarrier(uint32 state);
/* Prototypes for data checksum background worker */

2
src/include/replication/syncrep.h
View File

@@ -100,7 +100,7 @@ union YYSTYPE;
typedef void *yyscan_t;
extern int syncrep_yyparse(SyncRepConfigData **syncrep_parse_result_p, char **syncrep_parse_error_msg_p, yyscan_t yyscanner);
extern int syncrep_yylex(union YYSTYPE *yylval_param, char **syncrep_parse_error_msg_p, yyscan_t yyscanner);
extern void syncrep_yyerror(SyncRepConfigData **syncrep_parse_result_p, char **syncrep_parse_error_msg_p, yyscan_t yyscanner, const char *str);
extern void syncrep_yyerror(SyncRepConfigData **syncrep_parse_result_p, char **syncrep_parse_error_msg_p, yyscan_t yyscanner, const char *message);
extern void syncrep_scanner_init(const char *str, yyscan_t *yyscannerp);
extern void syncrep_scanner_finish(yyscan_t yyscanner);

2
src/include/tsearch/ts_locale.h
View File

@@ -56,7 +56,7 @@ ts_copychar_cstr(void *dest, const void *src)
#define COPYCHAR ts_copychar_cstr
#define GENERATE_T_ISCLASS_DECL(character_class) \
extern int t_is##character_class##_with_len(const char *ptr, int len); \
extern int t_is##character_class##_with_len(const char *ptr, int mblen); \
extern int t_is##character_class##_cstr(const char *ptr); \
extern int t_is##character_class##_unbounded(const char *ptr); \
\

8
src/pl/plperl/plperl.c
View File

@@ -248,7 +248,7 @@ static plperl_call_data *current_call_data = NULL;
**********************************************************************/
static PerlInterpreter *plperl_init_interp(void);
static void plperl_destroy_interp(PerlInterpreter **);
static void plperl_destroy_interp(PerlInterpreter **interp);
static void plperl_fini(int code, Datum arg);
static void set_interp_require(bool trusted);
@@ -284,12 +284,14 @@ static Datum plperl_hash_to_datum(SV *src, TupleDesc td);
static void plperl_init_shared_libs(pTHX);
static void plperl_trusted_init(void);
static void plperl_untrusted_init(void);
static HV *plperl_spi_execute_fetch_result(SPITupleTable *, uint64, int);
static HV *plperl_spi_execute_fetch_result(SPITupleTable *tuptable,
uint64 processed, int status);
static void plperl_return_next_internal(SV *sv);
static char *hek2cstr(HE *he);
static SV **hv_store_string(HV *hv, const char *key, SV *val);
static SV **hv_fetch_string(HV *hv, const char *key);
static void plperl_create_sub(plperl_proc_desc *desc, const char *s, Oid fn_oid);
static void plperl_create_sub(plperl_proc_desc *prodesc, const char *s,
Oid fn_oid);
static SV *plperl_call_perl_func(plperl_proc_desc *desc,
FunctionCallInfo fcinfo);
static void plperl_compile_callback(void *arg);

2
src/timezone/localtime.c
View File

@@ -86,7 +86,7 @@ static struct pg_tm *gmtsub(pg_time_t const *timep, int_fast32_t offset,
struct pg_tm *tmp);
static bool increment_overflow(int *ip, int j);
static bool increment_overflow_time(pg_time_t *tp, int_fast32_t j);
static int_fast64_t leapcorr(struct state const *sp, pg_time_t);
static int_fast64_t leapcorr(struct state const *sp, pg_time_t t);
static struct pg_tm *timesub(pg_time_t const *timep,
int_fast32_t offset, struct state const *sp,
struct pg_tm *tmp);