bee81f7864
Commite28cf96e9preprocessed the copies of a query level's PlaceHolderVars that were pushed down into its subqueries in a single walk at the start of subquery_planner. That was wrong in two ways. First, such copies can also be inserted later, when a join alias Var of the outer level is expanded within a LATERAL subquery or a SubLink's subselect and the alias expression contains a PHV. Those copies were never preprocessed, so a SubLink within them survived into the subquery's lateral references or into a SubPlan's argument list, tripping an assertion in identify_current_nestloop_params or failing in cost_qual_eval. Second, when a pushed-down copy directly contains another PHV of the same level, the walk preprocessed the inner one first and then the outer one, so the outer one's preprocessing ran into the SubPlans just created in the inner one and tripped an assertion in flatten_join_alias_vars. To fix, preprocess the copies right after join alias expansion instead: within preprocess_expression, just before SubLinks are turned into SubPlans, and for LATERAL subquery RTEs, right after their aliases are flattened. Preprocessing a copy handles everything within it, including any further copies nested inside its SubLinks, so the walker no longer looks inside a copy. Back-patch to v16, as with commite28cf96e9. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Richard Guo <guofenglinux@gmail.com> Discussion: https://postgr.es/m/CAHGQGwH-acRnAk1=Ki4EiAJEt67+Rz=_jyg7pbP_c6BK4oHZ4Q@mail.gmail.com Backpatch-through: 16
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.