6b9f40d49a
When prepare_sort_from_pathkeys() cannot find a pathkey's expression in the input plan's targetlist, it adds a resjunk entry computing an EquivalenceClass member's expression. It copied that expression as-is, without replacing lateral references with nestloop Params the way build_path_tlist() does for the rest of the targetlist. This matters when the sort key contains a PlaceHolderVar whose expression has a lateral reference, and the sort is placed directly atop the plan node that evaluates the PlaceHolderVar. The targetlist already contains the PlaceHolderVar, so the sort key is considered computable, but the entry added for it still has the outer relation's Var inside the PlaceHolderVar. If the node is a join, setrefs.c fails with "variable not found in subplan target lists". If it is a scan, setrefs.c leaves the Var in place, and the executor fetches it from the scan tuple, leading to wrong results. To fix, pass root to prepare_sort_from_pathkeys() and apply replace_nestloop_params() to the expression before adding it to the targetlist. Back-patch to all supported branches. Author: Richard Guo <guofenglinux@gmail.com> Discussion: https://postgr.es/m/CAMbWs49LWNm7_OxuW1V71wLi+Ev3KbfY1bMY36uydNKwSPnbtQ@mail.gmail.com Backpatch-through: 14
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.