The segment_close() callback is required to set ws_file to a negative value after closing a WAL segment, as documented in xlogreader.h. XLogReaderFree() only treated -1 as closed, so it could call segment_close() again if another negative value was used. This should not be an issue in practice, but all the other code paths in the tree use 0 as comparison base when dealing with ws_file, except for the line updated here. Let's be consistent, at least. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/asNr203eue0R4zpZ@bdtpg
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.