10cc5aa96a
Insist that the input lexemes be already sorted and non-duplicate. There's no good reason for them not to be, since the required ordering is simple and platform-independent. The previous coding was willing to re-sort them, but that left a gap: it didn't de-duplicate them. De-duplicating would potentially require merging position lists, which would be painful; we can't easily re-use tsvectorin()'s logic for that, since it uses a different temporary representation. Let's just dodge the problem by insisting the lexeme list be fully correct as-presented, as we were already doing for the position lists. Also, there was an oversight in the position-list checking: it did not verify that the first position isn't zero. tsvectorin() rejects that, so this should too. While these problems allow tsvectorrecv() to construct tsvectors that would not be generated internally, the vectors aren't so broken that we can't work with them. Therefore, the best course of action seems to be to apply these tighter rules in master but not back-patch. Back-patching might break application workflows that aren't causing any serious problems. Any such users will need to clean their data before loading it into PG >= v20, but they'd face that issue anyway, and a major update is a better time for it than a minor update. Bug: #19748 Reported-by: Ke <kehan5800@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19748-6075f0508fa1ffc0@postgresql.org
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.