database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-19 15:49:24 +03:00
Code Activity

Fix matching check in recovery test 042_low_level_backup

Browse Source 
042_low_level_backup compared the result of a query two times with a
comparison operator based on an integer, while the result should be
compared with a string.

The outcome of the tests is currently not impacted by this change.
However, it could be possible that the tests fail to detect future
issues if the query results become different, for some reason.

Oversight in 99b4a63bef.

Author: Sadhuprasad Patro <b.sadhu@gmail.com>
Discussion: https://postgr.es/m/CAFF0-CHhwNx_Cv2uy7tKjODUbeOgPrJpW4Rpf1jqB16_1bU2sg@mail.gmail.com
Backpatch-through: 17
This commit is contained in:
Michael Paquier
2025-10-17 13:06:04 +09:00
parent d372888ade
commit d1b80a31ed
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/recovery/t/042_low_level_backup.pl
View File

@@ -105,8 +105,8 @@ copy(
$node_replica->start;
ok($node_replica->safe_psql('postgres', $canary_query) == 0,
'canary is missing');
is($node_replica->safe_psql('postgres', $canary_query),
'0', 'canary is missing');
# Check log to ensure that crash recovery was used as there is no
# backup_label.
@@ -134,8 +134,8 @@ $node_replica->init_from_backup($node_primary, $backup_name,
has_restoring => 1);
$node_replica->start;
ok($node_replica->safe_psql('postgres', $canary_query) == 1,
'canary is present');
is($node_replica->safe_psql('postgres', $canary_query),
'1', 'canary is present');
# Check log to ensure that backup_label was used for recovery.
ok($node_replica->log_contains('starting backup recovery with redo LSN'),