From d1b80a31ed6dc185108af74f363bd6baad98104f Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Fri, 17 Oct 2025 13:06:04 +0900 Subject: [PATCH] Fix matching check in recovery test 042_low_level_backup 042_low_level_backup compared the result of a query two times with a comparison operator based on an integer, while the result should be compared with a string. The outcome of the tests is currently not impacted by this change. However, it could be possible that the tests fail to detect future issues if the query results become different, for some reason. Oversight in 99b4a63bef94. Author: Sadhuprasad Patro Discussion: https://postgr.es/m/CAFF0-CHhwNx_Cv2uy7tKjODUbeOgPrJpW4Rpf1jqB16_1bU2sg@mail.gmail.com Backpatch-through: 17 --- src/test/recovery/t/042_low_level_backup.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/recovery/t/042_low_level_backup.pl b/src/test/recovery/t/042_low_level_backup.pl index 5749a1df533..20b1abf8999 100644 --- a/src/test/recovery/t/042_low_level_backup.pl +++ b/src/test/recovery/t/042_low_level_backup.pl @@ -105,8 +105,8 @@ copy( $node_replica->start; -ok($node_replica->safe_psql('postgres', $canary_query) == 0, - 'canary is missing'); +is($node_replica->safe_psql('postgres', $canary_query), + '0', 'canary is missing'); # Check log to ensure that crash recovery was used as there is no # backup_label. @@ -134,8 +134,8 @@ $node_replica->init_from_backup($node_primary, $backup_name, has_restoring => 1); $node_replica->start; -ok($node_replica->safe_psql('postgres', $canary_query) == 1, - 'canary is present'); +is($node_replica->safe_psql('postgres', $canary_query), + '1', 'canary is present'); # Check log to ensure that backup_label was used for recovery. ok($node_replica->log_contains('starting backup recovery with redo LSN'),