database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

test_json_parser: Fix broken file ref and inverted result check

Browse Source 
A comma following a file ref in a perl print statement makes the
statement just print the file's GLOB rather than redirecting the
following arguments to the file. This meant the test was not testing any
contents and the logs were instead bulked up with what the test was
supposed to be testing.

Also, run_log() returns 1 for success, not 0, so the tests for the
return values were wrong. (We were getting 0 because of the comma error
above.)

Backpatch-thru: 17
This commit is contained in:
Andrew Dunstan
2026-08-18 09:06:05 -04:00
parent c5450dcb3f
commit 10a6960632
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/modules/test_json_parser/t/004_test_parser_perf.pl
View File

@@ -26,7 +26,7 @@ my ($fh, $fname) = tempfile(DIR => $dir);
# repeat the input json file 50 times in an array
print $fh, '[', $contents, ",$contents" x 49, ']';
print $fh '[', $contents, ",$contents" x 49, ']';
close($fh);
@@ -34,10 +34,10 @@ close($fh);
my ($result) = run_log([ $exe, "1", $fname ]);
ok($result == 0, "perf test runs with recursive descent parser");
ok($result, "perf test runs with recursive descent parser");
$result = run_log([ $exe, "-i", "1", $fname ]);
ok($result == 0, "perf test runs with table driven parser");
ok($result, "perf test runs with table driven parser");
done_testing();