From 10a6960632d4299324aaac69b25a9d9652b1fa0d Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Tue, 18 Aug 2026 09:06:05 -0400 Subject: [PATCH] test_json_parser: Fix broken file ref and inverted result check A comma following a file ref in a perl print statement makes the statement just print the file's GLOB rather than redirecting the following arguments to the file. This meant the test was not testing any contents and the logs were instead bulked up with what the test was supposed to be testing. Also, run_log() returns 1 for success, not 0, so the tests for the return values were wrong. (We were getting 0 because of the comma error above.) Backpatch-thru: 17 --- src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/modules/test_json_parser/t/004_test_parser_perf.pl b/src/test/modules/test_json_parser/t/004_test_parser_perf.pl index 81b8c8ae428..38960c0b244 100644 --- a/src/test/modules/test_json_parser/t/004_test_parser_perf.pl +++ b/src/test/modules/test_json_parser/t/004_test_parser_perf.pl @@ -26,7 +26,7 @@ my ($fh, $fname) = tempfile(DIR => $dir); # repeat the input json file 50 times in an array -print $fh, '[', $contents, ",$contents" x 49, ']'; +print $fh '[', $contents, ",$contents" x 49, ']'; close($fh); @@ -34,10 +34,10 @@ close($fh); my ($result) = run_log([ $exe, "1", $fname ]); -ok($result == 0, "perf test runs with recursive descent parser"); +ok($result, "perf test runs with recursive descent parser"); $result = run_log([ $exe, "-i", "1", $fname ]); -ok($result == 0, "perf test runs with table driven parser"); +ok($result, "perf test runs with table driven parser"); done_testing();