android/okhttp
1
0
Fork 0
mirror of https://github.com/square/okhttp.git synced 2026-01-22 15:42:00 +03:00
Code Releases Activity

Merge pull request #581 from square/jwilson_0301_gmt_dates

Browse Source 
Confirm that we use GMT formatting in setIfModifiedSince().
This commit is contained in:
Marcelo Cortes
2014-03-01 09:31:42 -05:00
parent edb8164469 5c3cfd9148
commit 3746efe897
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java
View File

@@ -1164,17 +1164,23 @@ public final class HttpResponseCacheTest {
return server.takeRequest();
}
/**
* Confirm that {@link URLConnection#setIfModifiedSince} causes an
* If-Modified-Since header with a GMT timestamp.
*
* https://code.google.com/p/android/issues/detail?id=66135
*/
@Test public void setIfModifiedSince() throws Exception {
Date since = new Date();
server.enqueue(new MockResponse().setBody("A"));
server.play();
URL url = server.getUrl("/");
URLConnection connection = openConnection(url);
connection.setIfModifiedSince(since.getTime());
connection.setIfModifiedSince(1393666200000L);
assertEquals("A", readAscii(connection));
RecordedRequest request = server.takeRequest();
assertTrue(request.getHeaders().contains("If-Modified-Since: " + formatDate(since)));
String ifModifiedSinceHeader = request.getHeader("If-Modified-Since");
assertEquals("Sat, 01 Mar 2014 09:30:00 GMT", ifModifiedSinceHeader);
}
@Test public void clientSuppliedConditionWithoutCachedResult() throws Exception {