From 5c3cfd9148500c19794aec4ba44c426247b7bd72 Mon Sep 17 00:00:00 2001 From: Jesse Wilson Date: Sat, 1 Mar 2014 09:15:56 -0500 Subject: [PATCH] Confirm that we use GMT formatting in setIfModifiedSince(). --- .../okhttp/internal/http/HttpResponseCacheTest.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java index 4cd8e7dc7..382fb561e 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java @@ -1164,17 +1164,23 @@ public final class HttpResponseCacheTest { return server.takeRequest(); } + /** + * Confirm that {@link URLConnection#setIfModifiedSince} causes an + * If-Modified-Since header with a GMT timestamp. + * + * https://code.google.com/p/android/issues/detail?id=66135 + */ @Test public void setIfModifiedSince() throws Exception { - Date since = new Date(); server.enqueue(new MockResponse().setBody("A")); server.play(); URL url = server.getUrl("/"); URLConnection connection = openConnection(url); - connection.setIfModifiedSince(since.getTime()); + connection.setIfModifiedSince(1393666200000L); assertEquals("A", readAscii(connection)); RecordedRequest request = server.takeRequest(); - assertTrue(request.getHeaders().contains("If-Modified-Since: " + formatDate(since))); + String ifModifiedSinceHeader = request.getHeader("If-Modified-Since"); + assertEquals("Sat, 01 Mar 2014 09:30:00 GMT", ifModifiedSinceHeader); } @Test public void clientSuppliedConditionWithoutCachedResult() throws Exception {