webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-31 10:54:46 +03:00
Code Activity

Remove escapeString completely

Browse Source 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This commit is contained in:
Kamil Tekiela
2024-01-09 03:35:09 +01:00
parent a3db5915d8
commit e5cc12235c
4 changed files with 0 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
psalm-baseline.xml
View File

@@ -5125,7 +5125,6 @@
<code><![CDATA[$this->connections[$connectionType]]]></code>
<code><![CDATA[$this->connections[$connectionType]]]></code>
<code><![CDATA[$this->connections[$connectionType]]]></code>
<code><![CDATA[$this->connections[$connectionType]]]></code>
<code><![CDATA[$this->versionComment]]></code>
<code><![CDATA[$this->versionString]]></code>
</MixedArgument>
@@ -13830,8 +13829,6 @@
<file src="tests/classes/Dbal/DbiDummyTest.php">
<DeprecatedMethod>
<code>Config::getInstance()</code>
<code>escapeString</code>
<code>escapeString</code>
</DeprecatedMethod>
<PossiblyUnusedMethod>
<code>errorData</code>

19
src/DatabaseInterface.php
View File

@@ -1878,25 +1878,6 @@ class DatabaseInterface implements DbalInterface
return "'" . $this->extension->escapeString($this->connections[$connectionType], $str) . "'";
}
/**
* returns properly escaped string for use in MySQL queries
*
* @deprecated Use {@see quoteString()} instead.
*
* @param string $str string to be escaped
* @psalm-param ConnectionType $connectionType
*
* @return string a MySQL escaped string
*/
public function escapeString(string $str, int $connectionType = Connection::TYPE_USER): string
{
if (isset($this->connections[$connectionType])) {
return $this->extension->escapeString($this->connections[$connectionType], $str);
}
return $str;
}
/**
* Returns properly escaped string for use in MySQL LIKE clauses.
* This method escapes only _, %, and /. It does not escape quotes or any other characters.

12
src/Dbal/DbalInterface.php
View File

@@ -563,18 +563,6 @@ interface DbalInterface
*/
public function quoteString(string $str, int $connectionType = Connection::TYPE_USER): string;
/**
* returns properly escaped string for use in MySQL queries
*
* @deprecated Use {@see quoteString()} instead.
*
* @param string $str string to be escaped
* @psalm-param ConnectionType $connectionType
*
* @return string a MySQL escaped string
*/
public function escapeString(string $str, int $connectionType = Connection::TYPE_USER): string;
/**
* Returns properly escaped string for use in MySQL LIKE clauses.
* This method escapes only _, %, and /. It does not escape quotes or any other characters.

15
tests/classes/Dbal/DbiDummyTest.php
View File

@@ -112,19 +112,4 @@ class DbiDummyTest extends AbstractTestCase
],
];
}
/**
* Test for string escaping
*/
public function testEscapeString(): void
{
$this->assertEquals(
'a',
$this->dbi->escapeString('a'),
);
$this->assertEquals(
'a\\\'',
$this->dbi->escapeString('a\''),
);
}
}