sysutils/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2026-10-24 02:09:03 +03:00
Code Activity

avformat/rtmpdh: fail bn_hex2bn() when bn_new() fails with GMP and mbedTLS

Browse Source 
This is not a security issue.

Fixes: d9RoImPBG3x8
Fixes: swarm-NULL-q1-passed-to-bn_modexp-when-GMP-MbedTLS-alloc-fails-c4db13
Regression since: 78efc69e7c (GMP), 62f5c9d68b (mbedTLS)
NULL bignum passed to bn_modexp() Replicated through Modified FFmpeg with ASAN (GMP and mbedTLS builds, the q1 allocation in ff_dh_generate_public_key() made to fail)
Found-by: zhang xingxing <2388969553@qq.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
zhang xingxing
2026-10-13 06:39:23 +02:00
committed by michaelni
parent 8d6ad744c6
commit f29e8dd79e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libavformat/rtmpdh.c
View File

@@ -95,7 +95,7 @@
if (bn) \
ret = (mpz_set_str(bn, buf, 16) == 0); \
else \
ret = 1; \
ret = 0; \
} while (0)
#define bn_random(bn, num_bits) \
do { \
@@ -198,7 +198,7 @@ static int bn_modexp(FFBigNum bn, FFBigNum y, FFBigNum q, FFBigNum p)
if (bn) \
ret = (mbedtls_mpi_read_string(bn, 16, buf) == 0); \
else \
ret = 1; \
ret = 0; \
} while (0)
#define bn_random(bn, num_bits) \
do { \