1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Commit Graph

308 Commits

Author SHA1 Message Date
Ruben Bridgewater
2ca42417bf Fix explicitly passing undefined as callback 2015-10-02 20:20:56 +02:00
Ruben Bridgewater
977d4dba2b Add host and port to options object 2015-09-30 02:35:11 +02:00
Ruben Bridgewater
3c39a8bdfc Remove .only 2015-09-30 02:12:28 +02:00
Ruben Bridgewater
afcd760b18 Fix a test and add some more 2015-09-30 02:04:56 +02:00
Ruben Bridgewater
fba050802b Move command out of the index.js 2015-09-30 02:03:37 +02:00
Ruben Bridgewater
29b31f749a Add a better promise documentation and add some tests 2015-09-30 01:57:58 +02:00
Ruben Bridgewater
db8c6e3bc2 Skip test until the issue is fixed 2015-09-25 02:23:41 +02:00
Ruben Bridgewater
5f261c5823 Minor changes
Move utility functions in lib/utils.js
Improve the js parser in cases the buffer is incomplete
Rename lib/parser to lib/parsers

Fix smaller issues with test suite and fix parser errors not being catched

Fixed wrong test for the new .end flush parameter
Fixed test suite options being partly mutated
Add some more tests
2015-09-25 02:12:48 +02:00
Ruben Bridgewater
bd4fca130d Make .end flush optional and add some tests 2015-09-24 13:27:32 +02:00
Ruben Bridgewater
38281c20b2 Fix small issues with hmset & multi constructor 2015-09-24 12:08:25 +02:00
Ruben Bridgewater
7be7128b2b Arguments passed as arrays should not be mutated. Fixes #866 2015-09-24 00:31:55 +02:00
Ruben Bridgewater
f29193a7e0 Investigate failure 2015-09-21 22:37:56 +02:00
Ruben Bridgewater
07154fce25 Fix typo 2015-09-21 22:30:35 +02:00
Ruben Bridgewater
55e4a9b847 Fix issues with returning buffers
Fixes #818 and #354
2015-09-21 03:07:55 +02:00
Ruben Bridgewater
6958c1854b Increase the coverage by adding tests and fix a failing ready check 2015-09-21 02:38:27 +02:00
Ruben Bridgewater
1cbf19ddf5 Hotfix for older node versions 2015-09-20 21:19:29 +02:00
Ruben Bridgewater
c60a3b65fe Rename .command_used to .command and add the used command to more errors 2015-09-20 18:56:21 +02:00
Ruben Bridgewater
1f121fa6e2 Fix error messages being manipulated. Fixes #695 2015-09-20 18:53:57 +02:00
Ruben Bridgewater
959b0ee093 Fix error codes for multi.exec and add more tests 2015-09-19 18:26:44 +02:00
Ruben Bridgewater
2293f7ff85 Add some more tests 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
40c037eaf4 Add redis error codes to the errors 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
083e446d23 Fix parser regression. Out of memory resulted in an endless loop 2015-09-19 17:48:25 +02:00
Ruben Bridgewater
26e5764214 Remove broken test 2015-09-19 17:48:25 +02:00
Ruben Bridgewater
f543d45d1f Fix and add more tests 2015-09-19 17:48:25 +02:00
pbihler
97db227a8d Fix for channel names with spaces. Fixes #691
Channel names with spaces were not properly resubscribed after a reconnection.
Conflicts:
	index.js
2015-09-18 02:44:29 +02:00
Ruben Bridgewater
28f31f134c Improve server keyspace info in .server_info 2015-09-18 01:51:40 +02:00
Ruben Bridgewater
46e2dc2de5 Fix memory leak. See #723 and thx to @rahar 2015-09-18 00:57:29 +02:00
Ruben Bridgewater
c846ed71d1 Merge pull request #826 from fintura/multi
Fix multi error handling
2015-09-18 00:38:05 +02:00
Ruben Bridgewater
4d1390318c Merge pull request #853 from fintura/eval
Remove bad .eval implementation
2015-09-18 00:17:35 +02:00
Ruben Bridgewater
d61d97e24e Fix .auth not working properly
The arguments parameter was faulty andthe callback could have been triggered twice
2015-09-18 00:05:10 +02:00
Ruben Bridgewater
8b7d4a8449 Remove bad .eval implementation
The implementation is not really good as mentioned in #722 and we pipline our commands.
That way we can't just replace the eval function as it was. This could result in violating the order of execution!

If we want to include a function like this we should not break the order of execution and also not recalculate the sha1 hash each time.
2015-09-17 22:51:42 +02:00
Ruben Bridgewater
21d8bdbbcb Refactor multi to have a consistent error handling
Ignore *.log files
2015-09-17 20:30:11 +02:00
Ruben Bridgewater
95a2c373a2 Fix broken build. The merge had a small conflict 2015-09-16 05:58:29 +02:00
Ruben Bridgewater
f92f4d0df9 Merge pull request #850 from fintura/fix-late-commands
Fix commands not being rejected after calling .quit

Fixes #791
2015-09-16 05:43:55 +02:00
Ruben Bridgewater
a0c906256c Fix commands not being rejected after calling .quit as reported in #791 2015-09-16 05:29:34 +02:00
Ruben Bridgewater
89c8dd056b Do not emit the broken mode twice if exec is called
Add more tests
2015-09-16 05:22:43 +02:00
Ruben Bridgewater
55d0036eae Add test and fix keeping the offline queue
Use a new delay after reconnecting
2015-09-16 05:22:07 +02:00
Ruben Bridgewater
3c2ba8c373 Try exactly until the connection timeout has been reached
Fixes #587
2015-09-16 05:22:07 +02:00
Ruben Bridgewater
03e8c03503 Add connection timeout and max attempts tests 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
0b8705abe9 Do not run all tests with every single connection (if one connection works, the others are going to be fine too) 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
1e0421ac3b Emit errors if the connection timeout / maximum retry attempts have been exceeded
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
2015-09-16 05:22:07 +02:00
Ruben Bridgewater
403bfb0200 Merge pull request #835 from fintura/remove-stuff
Remove send_command safety checks. Fixes #629
2015-09-16 05:21:18 +02:00
Ruben Bridgewater
eea9d2af76 Merge pull request #847 from fintura/check-password
Check that the password is from type string
2015-09-16 05:20:43 +02:00
Ruben Bridgewater
005e869d83 Remove send_command safety checks
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that

Fix #629 and insert tests
2015-09-16 05:10:39 +02:00
Ruben Bridgewater
c269b7539c Check that the password is from type string 2015-09-15 22:35:25 +02:00
Ruben Bridgewater
a0c92b0756 Add a lot more tests to indicate that the everything is consistent
Add a test for #390

More special cases
2015-09-15 04:14:40 +02:00
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
2015-09-15 04:00:02 +02:00
Ruben Bridgewater
ebbb0146b9 Fix auth emitting the error even though a callback is present
Fix auth manipulating the returned error
And this is also removing some dead code
2015-09-15 03:50:47 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
4bdcf8a598 Fix regression: version detection in tests did not work properly anymore 2015-09-14 23:53:52 +02:00