redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Rename .command_used to .command and add the used command to more errors

Browse Source
This commit is contained in:
Ruben Bridgewater
2015-09-20 18:56:21 +02:00
parent 1f121fa6e2
commit c60a3b65fe
5 changed files with 40 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/auth.spec.js
View File

@@ -41,7 +41,7 @@ describe("client authentication", function () {
client = redis.createClient.apply(redis.createClient, args);
client.once('error', function (err) {
assert.strictEqual(err.command_used, 'AUTH');
assert.strictEqual(err.command, 'AUTH');
assert.ok(/ERR invalid password/.test(err.message));
return done();
});
@@ -55,7 +55,7 @@ describe("client authentication", function () {
client = redis.createClient.apply(redis.createClient, args);
client.auth('', function (err, res) {
assert.strictEqual(err.command_used, 'AUTH');
assert.strictEqual(err.command, 'AUTH');
assert.ok(/ERR invalid password/.test(err.message));
done();
});
@@ -130,7 +130,7 @@ describe("client authentication", function () {
client = redis.createClient.apply(redis.createClient, args);
client.auth(undefined, function(err, res) {
assert.strictEqual(err.message, 'The password has to be of type "string"');
assert.strictEqual(err.command_used, 'AUTH');
assert.strictEqual(err.command, 'AUTH');
assert.strictEqual(res, undefined);
done();
});
@@ -142,7 +142,7 @@ describe("client authentication", function () {
client = redis.createClient.apply(redis.createClient, args);
client.on('error', function (err) {
assert.strictEqual(err.message, 'The password has to be of type "string"');
assert.strictEqual(err.command_used, 'AUTH');
assert.strictEqual(err.command, 'AUTH');
done();
});
client.auth(234567);

4
test/commands/multi.spec.js
View File

@@ -253,7 +253,7 @@ describe("The 'multi' method", function () {
assert.equal(reply, undefined, "The reply should have been discarded");
assert(err.message.match(/^EXECABORT/), "Error message should begin with EXECABORT");
assert.equal(err.errors.length, 2, "err.errors should have 2 items");
assert.strictEqual(err.errors[0].command_used, 'SET');
assert.strictEqual(err.errors[0].command, 'SET');
assert.strictEqual(err.errors[0].code, 'ERR');
assert.strictEqual(err.errors[0].position, 1);
assert(/^ERR/.test(err.errors[0].message), "Actuall error message should begin with ERR");
@@ -265,7 +265,9 @@ describe("The 'multi' method", function () {
client.multi().config("bar").debug("foo").eval("return {err='this is an error'}", 0).exec(function (err, reply) {
assert.strictEqual(reply.length, 3);
assert.equal(reply[0].code, 'ERR');
assert.equal(reply[0].command, 'CONFIG');
assert.equal(reply[2].code, undefined);
assert.equal(reply[2].command, 'EVAL');
assert(/^this is an error/.test(reply[2].message));
assert(/^ERR/.test(reply[0].message), "Error message should begin with ERR");
assert(/^ERR/.test(reply[1].message), "Error message should begin with ERR");

2
test/commands/select.spec.js
View File

@@ -94,7 +94,7 @@ describe("The 'select' method", function () {
assert.strictEqual(client.selected_db, null, "default db should be null");
client.on('error', function (err) {
assert.strictEqual(err.command_used, 'SELECT');
assert.strictEqual(err.command, 'SELECT');
assert.equal(err.message, 'ERR invalid DB index');
done();
});

8
test/node_redis.spec.js
View File

@@ -156,7 +156,9 @@ describe("The node_redis client", function () {
process.once('uncaughtException', function (err) {
process.on('uncaughtException', mochaListener);
assert(/ERR Protocol error/.test(err));
assert(/ERR Protocol error/.test(err.message));
assert.equal(err.command, true);
assert.equal(err.code, 'ERR');
done();
});
@@ -195,7 +197,7 @@ describe("The node_redis client", function () {
setTimeout(function() {
client.get("foo", function(err, res) {
assert.strictEqual(err.message, 'GET can\'t be processed. The connection has already been closed.');
assert.strictEqual(err.command_used, 'GET');
assert.strictEqual(err.command, 'GET');
assert.strictEqual(client.offline_queue.length, 0);
done();
});
@@ -209,7 +211,7 @@ describe("The node_redis client", function () {
client.quit();
client.on('error', function(err) {
assert.strictEqual(err.message, 'SET can\'t be processed. The connection has already been closed.');
assert.strictEqual(err.command_used, 'SET');
assert.strictEqual(err.command, 'SET');
assert.strictEqual(client.offline_queue.length, 0);
done();
});