1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-09 00:22:08 +03:00

readme: please include bench results on iffy pull requests

This commit is contained in:
DTrejo
2012-07-12 17:56:43 -07:00
parent f120cbd302
commit 49c73bac30

View File

@@ -592,6 +592,16 @@ I think there are more performance improvements left in there for smaller values
- your code should be the same style as the rest of the code - your code should be the same style as the rest of the code
- add your tests to `./test.js` - add your tests to `./test.js`
- add your documentation to `README.md` (if needed). - add your documentation to `README.md` (if needed).
- if you think your change will make node_redis slower, run this:
git checkout master
node multi_bench.js > before.txt
git checkout branch-with-your-change
node multi_bench.js > after.txt
./diff_multi_bench_output.js before.txt after.txt
and please attach a screenshot of the output (if it's not faster I recommend
trying to make it faster!).
- open a pull request! - open a pull request!
## Contributors ## Contributors