From 49c73bac304c89044e539bffae2a256627e8d0c6 Mon Sep 17 00:00:00 2001 From: DTrejo Date: Thu, 12 Jul 2012 17:56:43 -0700 Subject: [PATCH] readme: please include bench results on iffy pull requests --- README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/README.md b/README.md index 3cf5a9390f..6a06df7858 100644 --- a/README.md +++ b/README.md @@ -592,6 +592,16 @@ I think there are more performance improvements left in there for smaller values - your code should be the same style as the rest of the code - add your tests to `./test.js` - add your documentation to `README.md` (if needed). +- if you think your change will make node_redis slower, run this: + + git checkout master + node multi_bench.js > before.txt + git checkout branch-with-your-change + node multi_bench.js > after.txt + ./diff_multi_bench_output.js before.txt after.txt + + and please attach a screenshot of the output (if it's not faster I recommend + trying to make it faster!). - open a pull request! ## Contributors