The backend now reports an up-to-date list as a result, so the dialog shows an
info toast with the version rather than "could not update GFWList: … is up to
date".
Three endpoints answered FAIL for something the caller asked for and got:
- an up-to-date GFWList came back as "could not update GFWList: latest version
is …. GFWList is up to date", because the check returned an error;
- deleting the GFWList when it was already gone returned the raw
"remove …: no such file or directory";
- the update check said "failed to get latest version from Package file: 1".
The up-to-date case is now a sentinel error the controller turns into a
success carrying alreadyUpToDate, deleting what is already gone succeeds, and
the two package-index messages say what was missing. "which can not be nil"
also became a sentence about the request.
A rule that sends a name to a local resolver which forwards back to v2rayA
makes the two exchange the same query until one of them runs out of memory;
v2rayA/v2rayA discussion #1950 reproduces it with dnsmasq on OpenWrt. The
firewall-level self-redirect is already handled by the 0x80 mark, but nothing
saw the loop at the resolver level.
Every query this process sends upstream carries a random per-process token in
an EDNS0 local option. A query that arrives carrying that token has come back
around such a loop and is answered with SERVFAIL, with one log line per ten
seconds naming the question and how many were refused.
The README pointed at an image host upload from April 2020 showing an
interface that no longer exists. The new pair lives in the repository, so it
cannot disappear, and the dark one is served to readers whose system asks for
a dark theme.
A virtual scroller needs one fixed row height, so every log line was clipped at
the screen edge and a phone showed a column of timestamps with no messages. On
a narrow screen the tail is rendered plainly with the lines wrapped, and the
header says how many older lines are hidden.
The About text also still pointed at the issue tracker, which upstream has
closed in favour of discussions.
A DNS or connection failure produced "Could not download the asset from
api.github.com (HTTP )" in the GUI, because the localized message always
rendered an HTTP status and there was none. Unreachable hosts now use their own
code with the innermost reason, so the user sees the DNS or connection error
instead of an empty pair of brackets.
Auth recovery reloads the page, so nothing ever filled the queue and nothing
called its retry function; the two modal imports it needed were unused too.
Also read the token with getItem instead of hasOwnProperty on localStorage.
The outbound select rendered blank because nothing was selected, which reads as
an empty list — the reason two discussions report that a custom inbound cannot
be added at all (v2rayA/v2rayA #1907, #1894, #1926). It now preselects the
first outbound group, the fields sit on a grid instead of wrapping into a row
with the Add button wedged against the select, and the optional username and
password of the inbound have their own fields, with a lock on the rows that
carry credentials.
When the OOM killer takes v2rayA the core survives, is adopted by init and
keeps 20170/20171, so every later start failed with "port is already in use"
until someone killed it by hand (second half of v2rayA/v2rayA discussion
#1932). A process holding one of our ports that runs our core binary and whose
parent is init is ours to clean up.
The version mismatch also said only which two numbers differ, so users who had
installed xray-core concluded v2rayA was broken (#1930, #1903, #1891); it now
says which binary v2rayA needs.
A custom inbound port was open to anyone who could reach it, and older v2rayA
versions did offer authenticated inbounds, so users who relied on them had no
replacement (v2rayA/v2rayA discussions #1894, #1907).
CustomInbound carries optional credentials, which become the inbound's account
list. Half a credential pair is rejected: it would silently leave the port open.
The hijack wrote the file directly, so on any systemd-resolved, resolvconf or
openresolv system it overwrote the resolver's own file through the symlink and
destroyed the link; stopping the proxy then wrote a second hijacked file with
public resolvers rather than restoring anything. The machine was left bypassing
its resolver with no way back short of reinstalling, which is what v2rayA/v2rayA
discussion #1958 and defect B of #1920 describe.
Save the original first — the target when it is a symlink, the content
otherwise — replace the link instead of writing through it, and put the
original back on stop. Closing the hijacker now also waits for a tick that is
already writing, which used to put the hijacked file back after the restore.
node.vue read coreVersionValid from localStorage when it was created, and the
/version response of the current load only wrote localStorage afterwards. An
upgrade that made the core incompatible therefore showed nothing until the page
was reloaded, and a fixed one kept the warning for one more load. The parent
owns the value now and passes it down.
TestDown passed a directory where Down expects the destination file path and
then read the result from the working directory, so it could not pass; TestTemp
was a leftover scratch benchmark that wrote a 512 MiB file to a hard-coded
Windows path and called log.Fatal, which killed the whole test binary. Both
tests also fetch a file from GitHub and compare it with a fixed checksum.
Remove TestTemp, fix the destination, and run the two network tests only when
V2RAYA_NETWORK_TESTS=1. go test ./... is green now.
Shutdown asks for the teardown twice: pre_run calls CheckAndStopTransparentProxy
and then Stop calls it again through beforeStop. Both ran the user's pre-stop
and post-stop transparent hooks, so a hook that is not idempotent ran twice on
every exit.
Record whether this process installed the rules and make the teardown a no-op
once they are gone. Rules left behind by an earlier process are still removed
by cleanupResidualTransparentProxyRules when the next ones are written.
v2raya_core is started with XRAY_LOCATION_ASSET and looks nowhere else, while
v2rayA only created links in that directory as a side effect of looking a file
up for itself. On a host whose XDG runtime directory is cleared between login
sessions, the core then started with an empty asset directory and failed with
"failed to open geosite.dat" although the files were installed in
/usr/share/v2raya all along; the failure reads like a broken config.
Link the four dat files the core loads by name into that directory before
starting it, taking them from the XDG data directories or the two system
directories a distribution installs into.
- a shadowsocks userinfo arrives percent-escaped, and js-base64 decoded those
escapes as data, so opening a node for editing rewrote its password;
- the simple-obfs path is exported as obfs-uri, which the dialog did not read,
so saving an edited node dropped it;
- a plain trojan ws/h2 node lost its Host header, because the model never read
the host parameter although the serializer writes it;
- the plugin options were decoded twice, which turned %2F into a separator and
threw on a literal percent sign;
- the selection is remapped by what a row points at instead of its id, which a
subscription update reassigns;
- the burger set its display for every width, so a desktop window showed it
next to the full menu.
The shadowsocks userinfo, the vmess body and the SSR link trimmed a single "="
from their base64, so a value that needed two padding characters was exported
with one left over. A strict decoder rejects that, and a lenient one decodes
the stray character as data: editing such a shadowsocks node in the GUI turned
its password into "test\r..." because the escaped "=" reached the decoder.
A client that predates the kind field sends only the URL, so an http(s) link
had to be guessed. Guessing "subscription" is right for every address a
provider hands out, but it took away the bare proxy link 3fd0e882 had added:
credentials, host, port and nothing else cannot be a subscription address, so
that one shape goes back to the server importer.
Also let the config loader ignore every -test.* flag instead of only -test.v,
so the packages that reach it can run their tests at all.
Three gaps the settings rollback left open:
- adding or deleting a custom inbound stored the new list and then reloaded the
core; a core that refused the list stayed stopped with the rejected inbound
stored, so every later start failed too;
- a settings save that flipped ip forwarding left the kernel flag on the new
value after the setting itself was rolled back, so the stored setting and the
host disagreed;
- the rollback reported "the previous ones are back" even when restoring the
setting or restarting the core had failed as well.
The session secret now retries persistence instead of accepting a failed store
for the life of the process, and an unreadable secret row is no longer
overwritten with a fresh one, which would have signed out every session.
Three regressions from the previous transparent-proxy commit:
- the redirect ingress rules lost the "*" to "+" translation, so an excluded
interface pattern such as docker* stopped matching and Docker traffic was
redirected; the egress rules and both tproxy directions still translated it;
- the whitelist now parses its entries, and the GUI submits the textarea lines
as typed, so a pasted CIDR with surrounding whitespace aborted the whole
setup where the shell used to swallow it;
- the DNS readiness probe resolves a name, so a dead or slow upstream failed it
even with the listener up, and the core could no longer start at all. The
probe is now advisory: it still waits when DNS is healthy, but a failure is
logged instead of aborting the start.
Defaulting the port made an absent port legal, and with it a link that carries
no host at all: `socks5://` was accepted and stored as a node with an empty
server, where the previous port conversion had rejected it.
A Reality VLESS proxy carries reality-opts.spider-x and a TLS VMess proxy
carries client-fingerprint; both were dropped by the mapping, so the imported
node handshook with an empty spider path and the default fingerprint and the
provider's server could refuse it.
The signing secret was the hash of the subscription addresses, or of the
server hostnames when there was no subscription, so importing, editing or
deleting a server changed the secret and signed every session out mid-use.
Generate 32 random bytes on first use and keep them in the database.
UpdateSetting stored the new setting before asking the core to reload it. When
the core refused the new config, the controller stopped the core and left the
rejected setting in the database, so the proxy was down and the next save
reported success while nothing was running.
Snapshot the setting before storing it, and on a reload failure put it back and
restart the core with it. The response now carries INVALID_CONFIG and the
reason the core gave.
Truncating the navbar tags with display: inline-block blockified them as
flex items, so their text dropped to the baseline instead of the middle of
the pill. Keep Bulma's inline-flex centring and truncate an inner span
(7px above and below the text at every width now). The wordmark stays
40px tall next to them, which crowded the row; 34px below 769px, 26px
below 381px, and below 331px the tags and the menu button take the row.
reset.scss put filter: drop-shadow(0 0 5px #000) on every non-hovered
.modal-close, which on the light theme drew a black halo around the glyph.
The brand row is a flex row whose items do not shrink, so below ~400px the
status and proxy-group tags pushed the burger past the right edge and the
menu could not be opened at all; let the tags shrink with an ellipsis and
give the burger a fixed basis. Verified at 320/360/412/480: no horizontal
overflow, the burger is in view and opens the menu.
The navbar burger was still Bulma's three spans, the only control not drawn
from the icon set; render it through Buefy's burger slot as the Lucide menu
glyph (x when open) with an aria-label and the expanded state. On phones the
toolbar wrapped into three ragged rows because Bulma's per-field margins
fought the flex layout: stack the two groups as full-width rows with one
0.5rem gap, actions first and create/import right-aligned under them. The
close glyph was 0.55 black on a light head; darken it.
The dialog close button drew Bulma's two white bars, invisible on the light
card head; colour them from the text colour (19:1 light, 9.6:1 dark) and add
a hover surface. Four different backdrop values were in the tree, so a light
card sat on a near-black overlay that read as a shadow; keep one value in
App.vue and drop the per-component copies. The core-version notice becomes a
b-notification inside the content column instead of an edge-to-edge message.
In the collapsed navbar the language and account menus were clipped after
one row, because Bulma gives that menu overflow: auto with a max-height;
let it overflow and give the dropdown its own surface, border, shadow and
bounded scroll.
Bulma positions .modal-close fixed to the viewport, so the close button of
every dialog sat in the corner of the screen instead of the dialog; make it
absolute inside Buefy's .animation-content, which now shrinks to its card.
With mobile-modal dropdowns off, the collapsed navbar's language and
account menus floated over the page; anchor them under their row, capped at
the viewport width with their own scroll. The phone burger was a 3.5rem box
whose bars kept the scaled root font; give it a 48px square and explicit
bars.
Buefy turned every dropdown into a centred modal with a backdrop below
769px, so the account and language menus opened as dialogs; the close
button of a dialog is fixed to the viewport while Bulma floats the card
in the middle, so it sat far above the card it closes; repeated clicks on
a failing action stacked a screenful of identical toasts because every
call passed queue: false.
Keep dropdowns as menus on phones, give dialogs the full screen so the
close button lands on the card's top-right corner, and queue notices
(the per-call queue: false is gone). Inline Lucide glyphs are centred on
the text instead of sitting on the baseline, and the brand row keeps px
sizes under 768px, where the root font scales to 0.8em.
Every load and every remount showed the "service is running" toast, and a
core version mismatch showed twice: the persistent banner in node.vue and
a sticky red toast over it. Show the welcome once per browser session
(again when a new version is found) and leave the mismatch to the banner.