lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-10 05:22:59 +03:00
Code Activity

update all Windows jobs to windows-2019 (#1714)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/folly/pull/1714

windows-2016 will be removed in March, and now that we've updated
Boost, we can upgrade to windows-2019.

Reviewed By: genevievehelsel

Differential Revision: D34119171

fbshipit-source-id: caad432bebf6b8282844bf79f82b1fbc34f2df9e
This commit is contained in:
Chad Austin
2022-02-09 20:00:13 -08:00
committed by Facebook GitHub Bot
parent aae101ec66
commit f723ceb5c3
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
build/fbcode_builder/getdeps.py
View File

@@ -906,12 +906,8 @@ class GenerateGitHubActionsCmd(ProjectCmdBase):
artifacts = "linux" artifacts = "linux"
runs_on = f"ubuntu-{args.ubuntu_version}" runs_on = f"ubuntu-{args.ubuntu_version}"
elif build_opts.is_windows(): elif build_opts.is_windows():
# We're targeting the windows-2016 image because it has
# Visual Studio 2017 installed, and at the time of writing,
# the version of boost in the manifests (1.69) is not
# buildable with Visual Studio 2019
artifacts = "windows" artifacts = "windows"
runs_on = "windows-2016" runs_on = "windows-2019"
# The windows runners are python 3 by default; python2.exe # The windows runners are python 3 by default; python2.exe
# is available if needed. # is available if needed.
py3 = "python" py3 = "python"