From f723ceb5c326a11db23544151c41990452feed25 Mon Sep 17 00:00:00 2001 From: Chad Austin Date: Wed, 9 Feb 2022 20:00:13 -0800 Subject: [PATCH] update all Windows jobs to windows-2019 (#1714) Summary: Pull Request resolved: https://github.com/facebook/folly/pull/1714 windows-2016 will be removed in March, and now that we've updated Boost, we can upgrade to windows-2019. Reviewed By: genevievehelsel Differential Revision: D34119171 fbshipit-source-id: caad432bebf6b8282844bf79f82b1fbc34f2df9e --- build/fbcode_builder/getdeps.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index c0d5fa3ca..6272eec14 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -906,12 +906,8 @@ class GenerateGitHubActionsCmd(ProjectCmdBase): artifacts = "linux" runs_on = f"ubuntu-{args.ubuntu_version}" elif build_opts.is_windows(): - # We're targeting the windows-2016 image because it has - # Visual Studio 2017 installed, and at the time of writing, - # the version of boost in the manifests (1.69) is not - # buildable with Visual Studio 2019 artifacts = "windows" - runs_on = "windows-2016" + runs_on = "windows-2019" # The windows runners are python 3 by default; python2.exe # is available if needed. py3 = "python"