lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2026-10-24 01:33:54 +03:00
Code Activity

Find Boost.Filesystem directly in the OSS CMake build

Browse Source 
Summary:
EdenFS uses `boost::filesystem` directly in `EdenConfig`, `EdenMount`, `Overlay`, `FsInodeCatalog`, `EphemeralFsInodeCatalog`, `OverlayChecker`, `EdenInit`, `PrjfsDispatcherImpl` and the privhelper test server, but its CMake build never looks Boost up. It links only because folly's exported CMake config brings `Boost::filesystem` along. Once `folly::fs` moves to `std::filesystem` and folly drops that dependency (D125722811), the OSS EdenFS build fails to link.

Find Boost.Filesystem in `EdenConfigChecks.cmake` and link `Boost::filesystem` into the libraries that compile those files: `eden_config`, `eden_inodes`, `eden_fscatalog`, `eden_overlay_checker`, `eden_service` and `eden_fuse_privhelper_test`. The lookup omits `MODULE`, which permits Boost package-config fallback, so it keeps working where CMake no longer ships FindBoost (CMP0167). Add `boost` to the eden getdeps manifest. This matches the edencommon fix (D126570941).

Reviewed By: genevievehelsel

Differential Revision: D126769174

fbshipit-source-id: edb53a072e6de5510d51943a05a08c1ef2c06cd8
This commit is contained in:
Victor Zverovich
2026-10-21 19:05:54 -07:00
committed by meta-codesync[bot]
parent 3f1970b092
commit dc9f6ab561
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
build/fbcode_builder/manifests/eden
View File

@@ -18,6 +18,7 @@ builder = cmake
[dependencies]
blake3
boost
googletest
folly
fbthrift