lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-05 19:55:47 +03:00
Code Activity

Fix handling of -j in autoconf builder

Browse Source 
Summary:
The *string* `"false"`, which was being returned by default, will be interpreted as truthy. So we were never getting the `-j` arg on the `make` command.

Should be a nice little speed boost for some builds.

Reviewed By: chadaustin

Differential Revision: D78819581

fbshipit-source-id: a1b57f17185d189df25e913e06bcf71f8f540053
This commit is contained in:
Jacob Bower
2025-07-24 19:16:03 -07:00
committed by Facebook GitHub Bot
parent 180d1c8cf7
commit a3a665f7ed
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
build/fbcode_builder/getdeps/builder.py
View File

@@ -443,8 +443,8 @@ class AutoconfBuilder(BuilderBase):
self._check_cmd(["autoreconf", "-ivf"], cwd=self.src_dir, env=env) self._check_cmd(["autoreconf", "-ivf"], cwd=self.src_dir, env=env)
configure_cmd = [configure_path, "--prefix=" + self.inst_dir] + self.args configure_cmd = [configure_path, "--prefix=" + self.inst_dir] + self.args
self._check_cmd(configure_cmd, env=env) self._check_cmd(configure_cmd, env=env)
only_install = self.manifest.get("build", "only_install", "false", ctx=self.ctx) only_install = self.manifest.get("build", "only_install", ctx=self.ctx)
if not only_install: if not only_install or only_install.lower() == "false":
self._check_cmd([self._make_binary, "-j%s" % self.num_jobs], env=env) self._check_cmd([self._make_binary, "-j%s" % self.num_jobs], env=env)
self._check_cmd([self._make_binary, "install"], env=env) self._check_cmd([self._make_binary, "install"], env=env)