From a3a665f7eded685871c1e57fbf2d2dd03e6c7174 Mon Sep 17 00:00:00 2001 From: Jacob Bower Date: Thu, 24 Jul 2025 19:16:03 -0700 Subject: [PATCH] Fix handling of -j in autoconf builder Summary: The *string* `"false"`, which was being returned by default, will be interpreted as truthy. So we were never getting the `-j` arg on the `make` command. Should be a nice little speed boost for some builds. Reviewed By: chadaustin Differential Revision: D78819581 fbshipit-source-id: a1b57f17185d189df25e913e06bcf71f8f540053 --- build/fbcode_builder/getdeps/builder.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index c8debbcdc..030dd63f0 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -443,8 +443,8 @@ class AutoconfBuilder(BuilderBase): self._check_cmd(["autoreconf", "-ivf"], cwd=self.src_dir, env=env) configure_cmd = [configure_path, "--prefix=" + self.inst_dir] + self.args self._check_cmd(configure_cmd, env=env) - only_install = self.manifest.get("build", "only_install", "false", ctx=self.ctx) - if not only_install: + only_install = self.manifest.get("build", "only_install", ctx=self.ctx) + if not only_install or only_install.lower() == "false": self._check_cmd([self._make_binary, "-j%s" % self.num_jobs], env=env) self._check_cmd([self._make_binary, "install"], env=env)