lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2026-10-24 01:33:54 +03:00
Code Activity

eden: pass the test setting to cmake as BUILD_TESTS

Browse Source 
Summary: eden builds its tests only with `BUILD_TESTS`, an option that D125301396 adds later in this stack, off by default. getdeps builds a project's tests unless it gets `--no-tests`, and `build.sh`, `build.bat` and `getdeps.py test eden` rely on that, but eden's manifest has no `[cmake.defines.test=on]` section to pass the setting to cmake, so eden would get no tests. Like folly's, fizz's and wangle's manifests, eden's now sets `BUILD_TESTS=ON` when getdeps builds tests.

Reviewed By: bigfootjon

Differential Revision: D125255420

fbshipit-source-id: ac847928c4807880799c93ab7b93c6aec9ec040c
This commit is contained in:
Genevieve (Genna) Helsel
2026-10-22 16:56:04 -07:00
committed by meta-codesync[bot]
parent b96048c1bd
commit 6bebb3a8d6
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
build/fbcode_builder/manifests/eden
View File

@@ -122,5 +122,8 @@ USE_CARGO_VENDOR=ON
[cmake.defines.fb=on]
IS_FB_BUILD=ON
[cmake.defines.test=on]
BUILD_TESTS=ON
[depends.environment]
EDEN_VERSION_OVERRIDE