lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

don't pass --collection or --purpose to tpx in local runs

Browse Source 
Summary:
Fix local test runs. Previously, they were silently passing, because
they skipped tests that were unknown to tpx. Instead, treat local runs
separately from CI diff runs.

Reviewed By: xavierd

Differential Revision: D37287032

fbshipit-source-id: a3a88e117cd0e078e18c0f795bae467768d812a5
This commit is contained in:
Chad Austin
2022-06-21 14:23:58 -07:00
committed by Facebook GitHub Bot
parent 76714a18b4
commit 5e16a318e5
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
build/fbcode_builder/getdeps/builder.py
View File

@@ -877,7 +877,9 @@ if __name__ == "__main__":
if test_filter: if test_filter:
testpilot_args += ["--", test_filter] testpilot_args += ["--", test_filter]
if schedule_type == "continuous": if schedule_type == "diff":
runs.append(["--collection", "oss-diff", "--purpose", "diff"])
elif schedule_type == "continuous":
runs.append( runs.append(
[ [
"--tag-new-tests", "--tag-new-tests",
@@ -913,7 +915,7 @@ if __name__ == "__main__":
] ]
) )
else: else:
runs.append(["--collection", "oss-diff", "--purpose", "diff"]) runs.append([])
for run in runs: for run in runs:
self._run_cmd( self._run_cmd(