From 5e16a318e576a7ffcad64826157199624819ff73 Mon Sep 17 00:00:00 2001 From: Chad Austin Date: Tue, 21 Jun 2022 14:23:58 -0700 Subject: [PATCH] don't pass --collection or --purpose to tpx in local runs Summary: Fix local test runs. Previously, they were silently passing, because they skipped tests that were unknown to tpx. Instead, treat local runs separately from CI diff runs. Reviewed By: xavierd Differential Revision: D37287032 fbshipit-source-id: a3a88e117cd0e078e18c0f795bae467768d812a5 --- build/fbcode_builder/getdeps/builder.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 669f8ddfd..89d38f7ee 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -877,7 +877,9 @@ if __name__ == "__main__": if test_filter: testpilot_args += ["--", test_filter] - if schedule_type == "continuous": + if schedule_type == "diff": + runs.append(["--collection", "oss-diff", "--purpose", "diff"]) + elif schedule_type == "continuous": runs.append( [ "--tag-new-tests", @@ -913,7 +915,7 @@ if __name__ == "__main__": ] ) else: - runs.append(["--collection", "oss-diff", "--purpose", "diff"]) + runs.append([]) for run in runs: self._run_cmd(