lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

fix use before assignment case

Browse Source 
Summary: If retries is 0, then `0 < 0` is false, meaning we will skip the `while` loop completely and just try to read retcode, which was never assigned.

Reviewed By: fanzeyi

Differential Revision: D23999523

fbshipit-source-id: fac4a1104eba3585fb52fc8d83163cb1a87b8fee
This commit is contained in:
Genevieve Helsel
2020-09-30 13:37:04 -07:00
committed by Facebook GitHub Bot
parent 9ed22c26bb
commit 21ee1f0940
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/fbcode_builder/getdeps/builder.py
View File

@@ -709,7 +709,7 @@ if __name__ == "__main__":
args += ["-R", test_filter] args += ["-R", test_filter]
count = 0 count = 0
while count < retry: while count <= retry:
retcode = self._run_cmd( retcode = self._run_cmd(
args, env=env, use_cmd_prefix=use_cmd_prefix, allow_fail=True args, env=env, use_cmd_prefix=use_cmd_prefix, allow_fail=True
) )