From 21ee1f094006dd3c95d9101c7a88801403b6f695 Mon Sep 17 00:00:00 2001 From: Genevieve Helsel Date: Wed, 30 Sep 2020 13:37:04 -0700 Subject: [PATCH] fix use before assignment case Summary: If retries is 0, then `0 < 0` is false, meaning we will skip the `while` loop completely and just try to read retcode, which was never assigned. Reviewed By: fanzeyi Differential Revision: D23999523 fbshipit-source-id: fac4a1104eba3585fb52fc8d83163cb1a87b8fee --- build/fbcode_builder/getdeps/builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 121b43f45..63a5bb788 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -709,7 +709,7 @@ if __name__ == "__main__": args += ["-R", test_filter] count = 0 - while count < retry: + while count <= retry: retcode = self._run_cmd( args, env=env, use_cmd_prefix=use_cmd_prefix, allow_fail=True )