mirror of
https://github.com/facebookincubator/mvfst.git
synced 2025-11-25 15:43:13 +03:00
2f528e68c0
Summary: Draft-22 onwards uses two one byte length fields to encode connection ID length instead of one one byte length field. To support this without disrupting existing clients we need to make our parsing version dependent. This diff accomplishes it by special casing the existing Facebook client QUIC version (0xfaceb000), and changing the default Facebook client version going forward to 0xfaceb001. Note that this diff also changes the behavior of the ticket transport parameters. When we changed from draft-18 to draft-19 transport parameters I apparently forgot to update the ticket transport parameters to the new format. Reviewed By: yangchi Differential Revision: D16205090 fbshipit-source-id: e74a92fa959d308f4bb43bad76e58d4b58d07322
103 lines
3.3 KiB
C++
103 lines
3.3 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
*/
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <quic/common/test/TestUtils.h>
|
|
#include <quic/handshake/TransportParameters.h>
|
|
|
|
#include <fizz/record/test/ExtensionTestsBase.h>
|
|
|
|
using namespace folly;
|
|
using namespace fizz;
|
|
using namespace fizz::test;
|
|
|
|
namespace quic {
|
|
namespace test {
|
|
|
|
StringPiece clientParams{"ffa5000a0008000400049d7f3e7d"};
|
|
StringPiece d18ClientParams{"ffa5000efaceb0000008000400049d7f3e7d"};
|
|
StringPiece serverParams{"ffa5000a0008000400049d7f3e7d"};
|
|
StringPiece ticketParams{"ffa5000a0008000400049d7f3e7d"};
|
|
StringPiece d18TicketParams{"ffa5000efaceb0000008000400049d7f3e7d"};
|
|
|
|
TEST_F(ExtensionsTest, TestClientParams) {
|
|
auto exts = getExtensions(clientParams);
|
|
auto ext = getExtension<ClientTransportParameters>(exts);
|
|
EXPECT_EQ(ext->initial_version, folly::none);
|
|
EXPECT_EQ(ext->parameters.size(), 1);
|
|
EXPECT_EQ(
|
|
ext->parameters[0].parameter, TransportParameterId::initial_max_data);
|
|
EXPECT_EQ(
|
|
*getIntegerParameter(
|
|
TransportParameterId::initial_max_data, ext->parameters),
|
|
494878333ULL);
|
|
checkEncode(std::move(*ext), clientParams);
|
|
}
|
|
|
|
// We still need to be able to parse draft-18 client parameters.
|
|
TEST_F(ExtensionsTest, TestD18ClientParams) {
|
|
auto exts = getExtensions(d18ClientParams);
|
|
auto ext = getExtension<ClientTransportParameters>(exts);
|
|
EXPECT_EQ(ext->initial_version.value(), QuicVersion::MVFST_OLD);
|
|
EXPECT_EQ(ext->parameters.size(), 1);
|
|
EXPECT_EQ(
|
|
ext->parameters[0].parameter, TransportParameterId::initial_max_data);
|
|
EXPECT_EQ(
|
|
*getIntegerParameter(
|
|
TransportParameterId::initial_max_data, ext->parameters),
|
|
494878333ULL);
|
|
}
|
|
|
|
TEST_F(ExtensionsTest, TestServerParams) {
|
|
auto exts = getExtensions(serverParams);
|
|
auto ext = getExtension<ServerTransportParameters>(exts);
|
|
|
|
EXPECT_EQ(ext->negotiated_version, folly::none);
|
|
EXPECT_EQ(
|
|
ext->parameters[0].parameter, TransportParameterId::initial_max_data);
|
|
EXPECT_EQ(
|
|
*getIntegerParameter(
|
|
TransportParameterId::initial_max_data, ext->parameters),
|
|
494878333ULL);
|
|
checkEncode(std::move(*ext), serverParams);
|
|
}
|
|
|
|
TEST_F(ExtensionsTest, TestTicketParams) {
|
|
auto exts = getExtensions(ticketParams);
|
|
auto ext = getExtension<TicketTransportParameters>(exts);
|
|
|
|
EXPECT_EQ(ext->negotiated_version, folly::none);
|
|
EXPECT_EQ(ext->parameters.size(), 1);
|
|
EXPECT_EQ(
|
|
ext->parameters[0].parameter, TransportParameterId::initial_max_data);
|
|
EXPECT_EQ(
|
|
*getIntegerParameter(
|
|
TransportParameterId::initial_max_data, ext->parameters),
|
|
494878333ULL);
|
|
checkEncode(std::move(*ext), ticketParams);
|
|
}
|
|
|
|
// We still need to be able to parse draft-18 ticket parameters.
|
|
TEST_F(ExtensionsTest, TestD18TicketParams) {
|
|
auto exts = getExtensions(d18TicketParams);
|
|
auto ext = getExtension<TicketTransportParameters>(exts);
|
|
|
|
EXPECT_EQ(ext->negotiated_version.value(), QuicVersion::MVFST_OLD);
|
|
EXPECT_EQ(ext->parameters.size(), 1);
|
|
EXPECT_EQ(
|
|
ext->parameters[0].parameter, TransportParameterId::initial_max_data);
|
|
EXPECT_EQ(
|
|
*getIntegerParameter(
|
|
TransportParameterId::initial_max_data, ext->parameters),
|
|
494878333ULL);
|
|
}
|
|
}
|
|
}
|