8b718b5a66
Add bounds check to residue input
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
23bdeca64d
Add core constant time comparison
...
Unfortunately reusing the new function from the signed constant time
comparison is not trivial.
One option would be to do temporary conditional swaps which would prevent
qualifying input to const. Another way would be to add an additional
flag for the sign and make it an integral part of the computation, which
would defeat the purpose of having an unsigned core comparison.
Going with two separate function for now and the signed version can be
retired/compiled out with the legacy API eventually.
The new function in theory could be placed into either
`library/constant_time.c` or `library/bignum_new.c`. Going with the
first as the other functions in the second are not constant time yet and
this distinction seems more valuable for new (as opposed to belonging to
the `_core` functions.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
5f016650d7
Reuse Bignum core I/O functions
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
91dc67d31c
Allow (NULL, 0) as a representation of 0
...
- We don't check for NULL pointers this deep in the library
- Accessing a NULL pointer when the limb number is 0 as a mistake is the
very similar to any other out of bounds access
- We could potentially mandate at least 1 limb representation for 0 but
we either would need to enforce it or the implementation would be less
robust.
- Allowing zero limb representation - (NULL, 0) in particular - for zero
is present in the legacy interface, if we disallow it, the
compatibility code will need to deal with this (more code size and
opportunities for mistakes)
In summary, interpreting (NULL, 0) as the number zero in the core
interface is the least of the two evils.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
4670f88991
Reuse Bignum helper functions
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
4614b9ad1b
Move Bignum macros to common header
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:52 +01:00
6ff3536de5
Add tests for little endian core I/O
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:08:49 +01:00
f1d617deb8
Add tests for big endian core I/O
...
The test case where there were extra limbs in the MPI failed and this
commit contains the corresponding fix as well. (We used to use the
minimum required limbs instead of the actual limbs present.)
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:06:31 +01:00
ba5c139e4c
Add more validation to modulus life cycle
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:03:56 +01:00
281ccda8a5
Clean up mpi_mod_init/free
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:03:56 +01:00
5005edb36c
Fix typos
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-08-05 17:03:56 +01:00
c5328cf9a6
Add a set of I/O functions for the modulus structure
...
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com >
2022-08-05 17:03:56 +01:00
b903070cec
Add a set of I/O functions
...
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com >
2022-08-05 17:03:56 +01:00
0c655572dc
Build the new bignum_new.c file
...
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com >
2022-08-05 17:03:56 +01:00
f049dbfe94
Add the new modulus and the residue structures
...
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com >
2022-08-05 17:03:56 +01:00
5740ff5f1f
Merge pull request #5949 from Summer-ARM/mbedtls-psa-crypto-config
...
MBEDTLS_POLY1305_C and MBEDTLS_CHACHA20_C are needed when PSA_WANT_ALG_CHACHA20_POLY1305 is defined
2022-08-05 11:03:45 +02:00
b4983d4556
Merge pull request #6164 from mprse/md_ssl_test
...
Avoid use of MD in SSL test suite
2022-08-05 11:02:44 +02:00
f860f3742b
Merge pull request #6070 from wernerlewis/bignum_test_radix
...
Remove radix argument from bignum test functions
2022-08-05 11:01:07 +02:00
57d4c11c44
Merge pull request #6165 from mprse/md_x509_test
...
Avoid use of MD in X.509 write test suite
2022-08-04 10:11:03 +02:00
b3edc1576c
Merge pull request #2602 from edsiper/crt-symlink
...
x509_crt: handle properly broken links when looking for certificates
2022-08-03 13:05:29 +02:00
07e7fe516b
Merge pull request #6088 from tuvshinzayaArm/validation_remove_change_curve
...
Validation remove and change in files related to curve in library
2022-08-03 13:05:16 +02:00
7e1ee0f04b
Merge pull request #6114 from mman/development
...
Use double quotes to include private header file psa_crypto_cipher.h
2022-08-03 13:04:57 +02:00
4741e0b56c
Use double quotes to include private header file psa_crypto_cipher.h
...
Signed-off-by: Martin Man <mman@martinman.net >
Co-authored-by: Tom Cosgrove <81633263+tom-cosgrove-arm@users.noreply.github.com >
2022-08-02 12:44:35 +02:00
dc47fe71df
Use upper case for bignum string comparison
...
Test data which is compared as a hex string now uses upper case to
match output of mbedtls_mpi_write_string() output. This removes usage
of strcasecmp().
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:17:45 +01:00
3ccc116c35
Apply test data changes for conflicting cases
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:17:45 +01:00
a453c14a12
Remove radix arguments from tests added in 3.2
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:07:14 +01:00
efda01fb8c
Fix formatting in bignum test functions
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:07:14 +01:00
f65a327111
Remove remaining bignum radix args
...
Functions which are not covered by script, changes made to use radix
16.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:07:14 +01:00
9802d36168
Remove radix arg from bignum tests
...
Cases where radix was explictly declared are removed in most cases,
replaced using script. bignum arguments are represented as hexadecimal
strings. This reduces clutter in test data and makes bit patterns
clearer.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:07:14 +01:00
19b4cd893c
Remove radix arg from mbedtls_test_read_mpi
...
All uses have radix argument removed, using script.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-01 15:05:24 +01:00
54a544600f
test_suite_x509write: use psa_hash_compute() instead mbedtls_md()
...
Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com >
2022-08-01 16:03:17 +02:00
cc59c998d8
test_suite_ssl: make PSA build independent on MD module
...
Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com >
2022-08-01 14:29:56 +02:00
78ddc3e8fc
Merge pull request #6159 from tom-cosgrove-arm/fix-typos-in-md-files
...
Fix typographical errors in .md files found by cspell
2022-08-01 10:06:28 +02:00
919ff15ecf
Merge pull request #4686 from Kazuyuki-Kimura/patch_#2020
...
Fixed a bug that the little-endian Microblaze does not work when MBEDTLS_HAVE_ASM is defined
2022-07-29 17:08:11 +01:00
0b86ac1957
Fix typographical errors in .md files found by cspell
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2022-07-29 13:44:01 +01:00
27036c9e28
Merge pull request #6142 from tom-cosgrove-arm/fix-comments-in-docs-and-comments
...
Fix a/an typos in doxygen and other comments
2022-07-29 12:59:05 +01:00
257319a33e
Merge pull request #6133 from tom-cosgrove-arm/extend-query_compile_time_config-to-psa_want
...
Extend query_compile_time_config to PSA_WANT_xxx macros
2022-07-28 13:01:09 +01:00
1e48445aa0
Merge pull request #6104 from superna9999/6097-remove-useless-md-in-test
...
Remove useless use of MD in test functions
2022-07-28 11:35:56 +02:00
86669de348
Broke 2 long lines
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-28 10:31:16 +01:00
aba26d0099
Merge pull request #5963 from tom-daubney-arm/remove_ssl_compression_new
...
Remove use of SSL session compression
2022-07-28 10:28:23 +01:00
f6b8c3297a
Merge pull request #6065 from mpg/explore2
...
Driver-only hashes: RSA 1.5 and PK + strategy doc
2022-07-28 10:43:38 +02:00
ce7f18c00b
Fix a/an typos in doxygen and other comments
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2022-07-28 05:50:56 +01:00
68429fc44d
Fix a few more typos
...
Update link while at it.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2022-07-27 20:44:02 +02:00
fb389dde58
Enable invalid param test for ecp
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:23:02 +01:00
22f3654324
Remove NULL pointer validation in ecp.c
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:21:48 +01:00
8df9603e73
Enable invalid param test for ecjpake
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:20:22 +01:00
a891f83803
Re-introduce ENUM validation in ecjpake.c
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:20:08 +01:00
2b1ecdaf4e
Remove NULL pointer validation in ecjpake.c
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:20:08 +01:00
2392419c9d
Enable invalid param test in ecdh.c
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 15:19:46 +01:00
f69cac784a
Reintroduce enum validation ecdh.c
...
Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com >
2022-07-27 14:43:38 +01:00
