Dave Rodgman
8e19bb25b4
Update solution template to require VS2013
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2023-01-10 15:11:54 +00:00
Dave Rodgman
be73adc224
Update README and add changelog entry
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2023-01-10 15:11:54 +00:00
Dave Rodgman
5d62ad525d
Update some comments & error messages
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2023-01-10 15:11:54 +00:00
Dave Rodgman
2dc320551c
Rename VS2010 directory to VS2013 and update Makefiles etc
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2023-01-10 15:11:54 +00:00
Manuel Pégourié-Gonnard
28d4d43416
Merge pull request #6863 from valeriosetti/issue6830
...
Remove uses of mbedtls_ecp_curve_info in TLS (with USE_PSA)
2023-01-10 10:01:17 +01:00
Manuel Pégourié-Gonnard
3368724ade
Merge pull request #6870 from valeriosetti/issue6831
...
Document/test dependencies on ECP & Bignum
2023-01-10 09:25:41 +01:00
Valerio Setti
a0b97bc803
fix wrong type in debug message
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-09 19:10:32 +01:00
Valerio Setti
2c12185b88
test: fix dependencies on function and data files
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-09 18:00:39 +01:00
Valerio Setti
1e868ccbac
fix several typos and extra blank spaces
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-09 17:59:46 +01:00
Valerio Setti
2b5d3ded1f
remove remaining occurencies of mbedtls_ecc_group_to_psa() from TLS
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-09 11:04:52 +01:00
Manuel Pégourié-Gonnard
b17803682e
Merge pull request #6873 from mpg/fix-derive-key-exercise
...
Fix test function derive_key_exercise()
2023-01-06 11:50:05 +01:00
Gilles Peskine
cd0a565644
Merge pull request #6703 from yuhaoth/pr/tls13-misc-from-prototype
...
TLS 1.3: Upstream misc fix from prototype
2023-01-05 14:35:54 +01:00
Gilles Peskine
f07ddde980
Merge pull request #6876 from davidhorstmann-arm/disable-code-style-for-bn-asm
...
Check for Uncrustify errors in `code_style.py`
2023-01-05 14:35:16 +01:00
David Horstmann
78d566b216
Fix pylint warnings about comparison to True
...
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-05 10:02:09 +00:00
David Horstmann
8d1d6edb0b
Fix incorrect typing of function in code_style.py
...
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-05 09:59:35 +00:00
David Horstmann
bec95320ba
Don't restyle end of file
...
Move the *INDENT-ON* annotation to the end of the file so that
uncrustify does not restyle the later sections (since it introduces a
risk of future problems).
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-05 09:50:47 +00:00
Valerio Setti
8e45cdd440
fix wrong dependency for X509_TRUSTED_CERTIFICATE_CALLBACK
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-05 09:33:38 +01:00
Valerio Setti
8841d6b2f6
add missing dependency documentation for SSL_ASYNC_PRIVATE
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-05 08:40:24 +01:00
David Horstmann
c571c5b1f0
Check Uncrustify returncode in code_style.py
...
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-04 18:44:00 +00:00
David Horstmann
cb3b6ae580
Disable code style correction for bignum assembly
...
The inline assembly defined in bn_mul.h confuses code style parsing,
causing code style correction to fail. Disable code style correction for
the whole section gated by "#if defined(MBEDTLS_HAVE_ASM)" to prevent
this.
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-04 17:50:08 +00:00
Valerio Setti
67419f0e11
tls: fix + save code size when DEBUG_C is not enabled
...
Some PSA curves' symbols (PSA_WANT_) were not matching the corresponding
MBEDTLS_ECP_DP_. This was fixed together with the removal of extra code
when DEBUG_C is not enabled.
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-04 17:36:00 +01:00
Valerio Setti
40d9ca907b
tls: remove useless legacy function
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-04 16:08:04 +01:00
Manuel Pégourié-Gonnard
9502b56192
Fix test function derive_key_exercise()
...
mbedtls_test_psa_setup_key_derivation_wrap() returns 1 for success, 0
for error, so the test here was wrong.
This is just a hotfix in order to avoid a testing gap. Larger issues not
addressed here:
- I don't think we should just exit and mark the test as passed; if
we're not doing the actual testing this should be marked as SKIP.
- Returning 1 for success and 0 for failure is a violation of our
documented coding guidelines. We're also supposed to test with == 0 or
!= 0. Having consistent conventions is supposed to help avoid errors
like this.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2023-01-04 13:16:53 +01:00
Gilles Peskine
262851df1c
Merge pull request #6868 from davidhorstmann-arm/workaround-uncrustify-asm-defines
...
Workaround Uncrustify parsing of "asm"
2023-01-04 10:38:06 +01:00
Valerio Setti
a4bb0fabea
check_config: add missing dependencies for the build without BIGNUM
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-03 16:20:43 +01:00
Valerio Setti
e1655b8132
test: add test for building without BIGNUM_C
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-03 16:20:43 +01:00
Valerio Setti
73260b6e65
test: extend test_suite_ssl for testing new functions
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-03 16:05:02 +01:00
Valerio Setti
3322f611e6
test: verify that TLS and X509 are independent from mbedtls_ecp_curve functions
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-03 13:03:42 +01:00
Valerio Setti
18c9fed857
tls: remove dependency from mbedtls_ecp_curve functions
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2023-01-03 13:03:34 +01:00
David Horstmann
e3d8f31ba1
Workaround Uncrustify parsing of "asm"
...
The following code:
#ifndef asm
#define asm __asm
#endif
causes Uncrustify to stop correcting the rest of the file. This may be
due to parsing the "asm" keyword in the definition.
Work around this by wrapping the idiom in an *INDENT-OFF* comment
wherever it appears.
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2023-01-03 11:07:09 +00:00
Manuel Pégourié-Gonnard
7a389ddc84
Merge pull request #6784 from valeriosetti/issue6702
...
Make SHA224_C/SHA384_C independent from SHA256_C/SHA512_C
2023-01-03 09:36:58 +01:00
Janos Follath
b4b0bb737d
Merge pull request #5907 from mpg/use-psa-rsa-pss
...
Use PSA more often in `pk_verify_ext()`
2022-12-30 12:33:50 +00:00
Manuel Pégourié-Gonnard
4511ca063a
Use PSS-signed CRL for PSS tests
...
Otherwise, in builds without PKSC1_V15, tests that are supposed to
accept the certificate will fail, because once the cert is OK they will
move on to checking the CRL and will choke on its non-PSS signature.
Tests that are supposed to reject the cert due to an invalid signature
from the CA will not check the CRL because they don't recognize the CA
as valid, so they have no reason to check the CA's CRL. This was hiding
the problem until the recent commit that added a test where the cert is
supposed to be accepted.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2022-12-30 10:13:41 +01:00
Valerio Setti
ea8c88fcbb
test: fix some descriptions
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-29 11:08:35 +01:00
Manuel Pégourié-Gonnard
6ea0a8d883
Disable 'wrong salt len' PK test with USE_PSA
...
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2022-12-29 10:07:08 +01:00
Valerio Setti
62e1ebbbc7
changelog: fix text error
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-28 13:28:42 +01:00
Valerio Setti
c963bb11c7
test: remove SHA224 from default test driver config
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-28 12:58:14 +01:00
Gilles Peskine
b402e4bde1
Merge pull request #6595 from mfischer/lms_heap
...
lms: Move merkle tree generation to heap allocation
2022-12-23 18:29:04 +01:00
Gilles Peskine
8eee21e3b3
Merge pull request #6836 from gilles-peskine-arm/code-style-more-kr-20221222
...
Tweak code style to be more like K&R
2022-12-23 18:23:37 +01:00
Valerio Setti
326cf46764
test: improved readability in sha self tests
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-23 14:57:18 +01:00
Valerio Setti
e269750f0d
sha: fix description for starts functions
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-23 14:29:54 +01:00
Valerio Setti
77b1452784
test: fix error in test_suite_ssl
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-23 10:53:06 +01:00
Manuel Pégourié-Gonnard
676766ff77
Merge pull request #6776 from gabor-mezei-arm/6222_bignum_mod_mul
...
Bignum: Implement fixed width modular multiplication
2022-12-23 10:39:30 +01:00
Manuel Pégourié-Gonnard
2fcb4c1d06
Merge pull request #6747 from gilles-peskine-arm/bignum-mod-random
...
Bignum mod random
2022-12-23 10:36:22 +01:00
Gilles Peskine
e19d7e5141
Require a space after a cast
...
Align with K&R2.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-12-22 23:18:30 +01:00
Valerio Setti
fe6c19b69c
added changelog file for PR #6784
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-22 15:05:27 +01:00
Valerio Setti
65287636f8
config: remove SHA224_C from some config files
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-22 14:29:40 +01:00
Valerio Setti
b6bf7dcc28
test: fix depends.py for hash tests
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-22 14:28:03 +01:00
Valerio Setti
543d00ef6f
sha: remove SHA1 from ssl_cookie
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-22 14:27:34 +01:00
Valerio Setti
d55cb5b3f0
sha: decline MD defines for various SHA
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-12-22 14:26:55 +01:00