lib/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2026-10-24 01:09:01 +03:00
Code Activity

parser: Fix memory leak in xmlCtxtSetSaxHandler

Browse Source
This commit is contained in:
Nick Wellnhofer
2026-07-20 02:27:48 +02:00
parent c8eaf2236f
commit ddcb79dc99
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
parserInternals.c
View File

@@ -3189,17 +3189,10 @@ xmlCtxtGetSaxHandler(xmlParserCtxt *ctxt) {
*/
int
xmlCtxtSetSaxHandler(xmlParserCtxt *ctxt, const xmlSAXHandler *sax) {
xmlSAXHandler *copy;
if ((ctxt == NULL) || (sax == NULL))
if ((ctxt == NULL) || (ctxt->sax == NULL) || (sax == NULL))
return(-1);
copy = xmlMalloc(sizeof(*copy));
if (copy == NULL)
return(-1);
memcpy(copy, sax, sizeof(*copy));
ctxt->sax = copy;
*ctxt->sax = *sax;
return(0);
}

9
testparser.c
View File

@@ -279,7 +279,7 @@ testSwitchDtdExtSubset(void *vctxt, const xmlChar *name ATTRIBUTE_UNUSED,
const xmlChar *systemId ATTRIBUTE_UNUSED) {
xmlParserCtxtPtr ctxt = vctxt;
ctxt->myDoc->extSubset = ctxt->_private;
ctxt->myDoc->extSubset = xmlCtxtGetPrivate(ctxt);
}
static int
@@ -291,6 +291,7 @@ testSwitchDtd(void) {
"<doc>&test;</doc>\n";
xmlParserInputBufferPtr input;
xmlParserCtxtPtr ctxt;
xmlSAXHandler sax;
xmlDtdPtr dtd;
xmlDocPtr doc;
xmlEntityPtr ent;
@@ -302,8 +303,10 @@ testSwitchDtd(void) {
dtd = xmlIOParseDTD(NULL, input, XML_CHAR_ENCODING_NONE);
ctxt = xmlNewParserCtxt();
ctxt->_private = dtd;
ctxt->sax->externalSubset = testSwitchDtdExtSubset;
xmlCtxtSetPrivate(ctxt, dtd);
xmlSAXVersion(&sax, 2);
sax.externalSubset = testSwitchDtdExtSubset;
xmlCtxtSetSaxHandler(ctxt, &sax);
doc = xmlCtxtReadMemory(ctxt, docContent, sizeof(docContent) - 1, NULL,
NULL, XML_PARSE_NOENT | XML_PARSE_DTDLOAD);
xmlFreeParserCtxt(ctxt);