lib/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2025-10-21 14:53:44 +03:00
Code Activity

malloc-fail: Fix memory leak in xmlSchemaParseUnion

Browse Source 
Also report malloc failure from xmlStrndup.

Found with libFuzzer, see #344.
This commit is contained in:
Nick Wellnhofer
2023-03-05 14:10:41 +01:00
parent 260d6b8d77
commit 961a4f35bf
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
xmlschemas.c
View File

@@ -9032,6 +9032,11 @@ xmlSchemaParseUnion(xmlSchemaParserCtxtPtr ctxt, xmlSchemaPtr schema,
if (end == cur)
break;
tmp = xmlStrndup(cur, end - cur);
if (tmp == NULL) {
xmlSchemaPErrMemory(ctxt, "xmlSchemaParseUnion, "
"duplicating type name", NULL);
return (-1);
}
if (xmlSchemaPValAttrNodeQNameValue(ctxt, schema,
NULL, attr, BAD_CAST tmp, &nsName, &localName) == 0) {
/*
@@ -9042,6 +9047,7 @@ xmlSchemaParseUnion(xmlSchemaParserCtxtPtr ctxt, xmlSchemaPtr schema,
if (link == NULL) {
xmlSchemaPErrMemory(ctxt, "xmlSchemaParseUnion, "
"allocating a type link", NULL);
FREE_AND_NULL(tmp)
return (-1);
}
link->type = NULL;