lib/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2026-01-26 21:41:34 +03:00
Code Activity

memory: Grow dynamic arrays by 50%

Browse Source 
Growing by a factor lower than the golden ratio increases the chances of
reusing memory freed from earlier allocations. Set growth rate to 1.5
which also reduces internal fragmentation.
This commit is contained in:
Nick Wellnhofer
2024-12-16 18:54:36 +01:00
parent b9feb81632
commit 2e18e5dc6d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/private/memory.h
View File

@@ -31,6 +31,8 @@ xmlCleanupMemoryInternal(void);
*/
static XML_INLINE int
xmlGrowCapacity(int capacity, size_t elemSize, int min, int max) {
int extra;
if (capacity <= 0) {
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
(void) min;
@@ -44,10 +46,13 @@ xmlGrowCapacity(int capacity, size_t elemSize, int min, int max) {
((size_t) capacity > SIZE_MAX / 2 / elemSize))
return(-1);
if (capacity > max / 2)
/* Grow by 50% */
extra = (capacity + 1) / 2;
if (capacity > max - extra)
return(max);
return(capacity * 2);
return(capacity + extra);
}
#endif /* XML_MEMORY_H_PRIVATE__ */