lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2026-10-24 03:48:58 +03:00
Code Activity

GHA: fix and re-enable Libgcrypt tests

Browse Source 
Use the last known good test container build, with debian:bookworm, for
Libgcrypt tests.

Also:
- disable running non-containerized sshd tests in the clang-tidy job,
  because it uses the latest Ubuntu (26.04) which, as debian-trixie,
  comes with a modern OpenSSH server that's incompatible with libssh2's
  Libgcrypt backend:
  ```
  26: [libssh2] 0.055233 Failure Event: -5 - Unable to exchange encryption keys
  26: libssh2_session_handshake failed (-5): Unable to exchange encryption keys
  26: not ok 2 - sshd-test_auth_pubkey_ok_ed25519
  26/44 Test #26: test_sshd .................................***Failed    0.58 sec
  # sshd executable: '/usr/sbin/sshd' (OpenSSH_10.2p1 Ubuntu)
  # sshd log: '/tmp/tmp.QdEw2bfbFE'
  # ssh executable: '/usr/bin/ssh' (OpenSSH_10.2p1 Ubuntu-2ubuntu3.2, OpenSSL 3.5.5 27 Jan 2026)
  # ssh log: '/tmp/tmp.TDLIzPY6zV'
  1..2
  ```
  Ref: https://github.com/libssh2/libssh2/actions/runs/28610019322/job/84839842924?pr=2174#step:25:18669
- run Libgcrypt jobs on ubuntu-24.04 (was: ubuntu-latest) to ensure it
  continues working after ubuntu-latest is bumped.

Ref: https://github.com/libssh2/libssh2/pkgs/container/ci_tests_openssh_server/409796170?tag=98199e448a94451491c4
Ref: https://github.com/libssh2/libssh2/discussions/2049
Follow-up to 51f6259d18 #1720

Closes #2174
This commit is contained in:
Viktor Szakats
2026-07-02 12:02:50 +02:00
parent 21840ddf0b
commit 8be5716437
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
.github/workflows/ci.yml vendored
View File

@@ -227,7 +227,7 @@ jobs:
build_linux:
name: 'linux'
runs-on: ${{ matrix.compiler == 'clang-tidy' && 'ubuntu-26.04' || (matrix.image || 'ubuntu-latest') }}
runs-on: ${{ matrix.compiler == 'clang-tidy' && 'ubuntu-26.04' || (matrix.image || (matrix.crypto == 'Libgcrypt' && 'ubuntu-24.04' || 'ubuntu-latest')) }}
timeout-minutes: 10
strategy:
fail-fast: false
@@ -573,6 +573,9 @@ jobs:
options+=' -DCMAKE_C_STANDARD=90'
cflags+=' -D_DEFAULT_SOURCE' # for glibc ISO mode, in tests: popen(), pclose(), in examples: fileno(), tcsetattr()
fi
if [ "${MATRIX_CRYPTO}" = 'Libgcrypt' ] && [ "${MATRIX_COMPILER}" = 'clang-tidy' ]; then
options+=' -DRUN_SSHD_TESTS=OFF' # fails on due to lack of support for modern algos offered by sshd on Ubuntu 26.04 used with clang-tidy
fi
if [ "${MATRIX_CRYPTO}" = 'OpenSSL-3-no-deprecated' ]; then
options+=' -DENABLE_DEBUG_LOGGING=ON'
fi
@@ -617,14 +620,20 @@ jobs:
fi
- name: 'tests'
if: ${{ !matrix.target && matrix.crypto != 'Libgcrypt' }}
if: ${{ !matrix.target }}
timeout-minutes: 10
run: |
if [ "${MATRIX_CRYPTO}" = 'OpenSSL-3-no-deprecated' ]; then
export FIXTURE_TRACE_ALL_CONNECT=1 # try to close in on flaky CI failures
fi
if [ "${MATRIX_BUILD}" = 'CM' ]; then
export OPENSSH_SERVER_IMAGE; OPENSSH_SERVER_IMAGE=ghcr.io/libssh2/ci_tests_openssh_server:$(git rev-parse --short=20 HEAD:tests/openssh_server)
export OPENSSH_SERVER_IMAGE
if [ "${MATRIX_CRYPTO}" = 'Libgcrypt' ]; then
# use debian:bookworm for diffie-hellman-group* KEXs
OPENSSH_SERVER_IMAGE=ghcr.io/libssh2/ci_tests_openssh_server:98199e448a94451491c4
else
OPENSSH_SERVER_IMAGE=ghcr.io/libssh2/ci_tests_openssh_server:$(git rev-parse --short=20 HEAD:tests/openssh_server)
fi
[ -d "$HOME"/usr ] && export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$HOME/usr/lib"
cd bld && ctest -VV --output-on-failure
else