lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2026-10-24 03:48:58 +03:00
Code Activity

wincng: fix builds with RSA and DSA disabled

Browse Source 
Fixing:
```
x86_64-w64-mingw32-ld: src/CMakeFiles/libssh2_shared.dir/Unity/unity_0_c.c.obj: in function `userauth_hostbased_fromfile':
src/userauth.c:923:(.text+0x34c29): undefined reference to `ssh2_pub_privkey'
x86_64-w64-mingw32-ld: src/CMakeFiles/libssh2_shared.dir/Unity/unity_0_c.c.obj: in function `userauth_publickey':
src/userauth.c:1745:(.text+0x37171): undefined reference to `ssh2_pub_privkey'
collect2: error: ld returned 1 exit status
```

Note: This fixes the build, but leaves `ssh2_pub_privkey()` a no-op, because it's not implemented for ECDSA.

Closes #2600
This commit is contained in:
Viktor Szakats
2026-09-11 20:17:17 +02:00
parent 65a9333204
commit 3f26c15b2f
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/wincng.c
View File

@@ -2705,6 +2705,7 @@ cleanup:
return ret;
}
#endif /* LIBSSH2_RSA || LIBSSH2_DSA */
int ssh2_pub_privkey(LIBSSH2_SESSION *session, char **method,
unsigned char **pubkeydata, size_t *pubkeydata_len,
@@ -2712,6 +2713,7 @@ int ssh2_pub_privkey(LIBSSH2_SESSION *session, char **method,
const char *privkeyblob, size_t privkeyblob_len,
const char *passphrase)
{
#if LIBSSH2_RSA || LIBSSH2_DSA
unsigned char *pbEncoded;
size_t cbEncoded;
@@ -2723,8 +2725,21 @@ int ssh2_pub_privkey(LIBSSH2_SESSION *session, char **method,
return wcng_pub_priv_parse(session, method,
pubkeydata, pubkeydata_len,
pbEncoded, cbEncoded);
#else
(void)session;
(void)method;
(void)pubkeydata;
(void)pubkeydata_len;
(void)privkeyfile;
(void)privkeyblob;
(void)privkeyblob_len;
(void)passphrase;
/* FIXME: add ECDSA support */
return -1;
#endif
}
#endif /* LIBSSH2_RSA || LIBSSH2_DSA */
/*******************************************************************/
/*