lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2026-10-24 03:48:58 +03:00
Code Activity

clang-tidy: fix readability-redundant-casting findings

Browse Source 
Do not enforce due to false positives.

Ref: https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-casting.html

Closes #2586
This commit is contained in:
Viktor Szakats
2026-09-04 13:11:08 +02:00
parent c4ae6510ef
commit 0b915eab67
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy.yml
View File

@@ -36,6 +36,7 @@ Checks:
- readability-inconsistent-declaration-parameter-name
- readability-misleading-indentation
- readability-named-parameter
# readability-redundant-casting # false positives in types that change from platform to platform, even with IgnoreTypeAliases: true
- readability-redundant-control-flow
- readability-redundant-declaration
- readability-redundant-function-ptr-dereference

4
src/kex.c
View File

@@ -1817,7 +1817,7 @@ static int kex_method_ecdh_key_exchange(
ret = kex_ecdh_sha2_nistp(session, curve, key_state->data,
key_state->data_len,
(unsigned char *)key_state->public_key_oct,
key_state->public_key_oct,
key_state->public_key_oct_len,
key_state->private_key,
&key_state->exchange_state);
@@ -2165,7 +2165,7 @@ static int kex_method_mlkem_nistp_key_exchange(
if(key_state->state == ssh2_NB_state_sent2) {
ret = kex_mlkem_nistp(session, key_state->data, key_state->data_len,
(unsigned char *)key_state->public_key_oct,
key_state->public_key_oct,
key_state->public_key_oct_len,
key_state->private_key,
key_state->mlkem_public_key,

4
src/sftp.c
View File

@@ -3008,8 +3008,8 @@ static int sftp_posix_rename(LIBSSH2_SFTP *sftp, const char *source_filename,
}
else if(rc) {
sftp->posix_rename_state = ssh2_NB_state_idle;
return (int)ssh2_err(session, (int)rc,
"Error waiting for FXP EXTENDED REPLY");
return ssh2_err(session, (int)rc,
"Error waiting for FXP EXTENDED REPLY");
}
sftp->posix_rename_state = ssh2_NB_state_idle;