1
0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-09-02 17:21:15 +03:00

Fix ssh_write_knownhost() which always returned -1.

fwrite() return the the number of items written not the size of the
buffer.
This commit is contained in:
Andreas Schneider
2009-07-21 14:07:23 +02:00
parent 41a8fb5810
commit b534bfc520
2 changed files with 6 additions and 4 deletions

View File

@@ -1576,7 +1576,7 @@ int ssh_write_knownhost(SSH_SESSION *session) {
}
len = strlen(buffer);
if (fwrite(buffer, len, 1, file) != len || ferror(file)) {
if (fwrite(buffer, len, 1, file) != 1 || ferror(file)) {
fclose(file);
return -1;
}

View File

@@ -476,7 +476,6 @@ int main(int argc, char **argv){
/* fallback to SSH_SERVER_NOT_KNOWN behavior */
case SSH_SERVER_NOT_KNOWN:
hexa = ssh_get_hexa(hash, hlen);
free(hash);
fprintf(stderr,"The server is unknown. Do you trust the host key ?\n");
fprintf(stderr, "Public key hash: %s\n", hexa);
free(hexa);
@@ -488,8 +487,11 @@ int main(int argc, char **argv){
fprintf(stderr,"This new key will be written on disk for further usage. do you agree ?\n");
fgets(buf,sizeof(buf),stdin);
if(strncasecmp(buf,"yes",3)==0){
if(ssh_write_knownhost(session))
fprintf(stderr,"error %s\n",ssh_get_error(session));
if (ssh_write_knownhost(session) < 0) {
free(hash);
fprintf(stderr, "error %s\n", strerror(errno));
exit(-1);
}
}
break;