1
0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-12-05 01:02:39 +03:00

gssapi: Free mic_buffer on all code paths (GHSL-2023-042)

Thanks Phil Turnbull from GitHub

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2023-03-06 12:31:59 +01:00
committed by Andreas Schneider
parent bb4e6ad1ee
commit 0a9b5bcd45

View File

@@ -949,8 +949,10 @@ static int ssh_gssapi_send_mic(ssh_session session)
maj_stat = gss_get_mic(&min_stat,session->gssapi->ctx, GSS_C_QOP_DEFAULT,
&mic_buf, &mic_token_buf);
SSH_BUFFER_FREE(mic_buffer);
if (GSS_ERROR(maj_stat)){
SSH_BUFFER_FREE(mic_buffer);
ssh_gssapi_log_error(SSH_LOG_DEBUG,
"generating MIC",
maj_stat,
@@ -967,7 +969,6 @@ static int ssh_gssapi_send_mic(ssh_session session)
gss_release_buffer(&min_stat, &mic_token_buf);
if (rc != SSH_OK) {
SSH_BUFFER_FREE(mic_buffer);
ssh_set_error_oom(session);
return SSH_ERROR;
}