From 0a9b5bcd4577624293a6868ca4acca261ab060bd Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Mon, 6 Mar 2023 12:31:59 +0100 Subject: [PATCH] gssapi: Free mic_buffer on all code paths (GHSL-2023-042) Thanks Phil Turnbull from GitHub Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/gssapi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gssapi.c b/src/gssapi.c index ce1c68aa..bea43277 100644 --- a/src/gssapi.c +++ b/src/gssapi.c @@ -949,8 +949,10 @@ static int ssh_gssapi_send_mic(ssh_session session) maj_stat = gss_get_mic(&min_stat,session->gssapi->ctx, GSS_C_QOP_DEFAULT, &mic_buf, &mic_token_buf); + + SSH_BUFFER_FREE(mic_buffer); + if (GSS_ERROR(maj_stat)){ - SSH_BUFFER_FREE(mic_buffer); ssh_gssapi_log_error(SSH_LOG_DEBUG, "generating MIC", maj_stat, @@ -967,7 +969,6 @@ static int ssh_gssapi_send_mic(ssh_session session) gss_release_buffer(&min_stat, &mic_token_buf); if (rc != SSH_OK) { - SSH_BUFFER_FREE(mic_buffer); ssh_set_error_oom(session); return SSH_ERROR; }