mirror of
https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git
synced 2026-10-25 12:39:18 +03:00
a2c92c9ece
In line_settings_init() we call gpiod_line_settings_set_edge_detection()
twice unnecessarily. Remove the second call.
Fixes: b7ba732e6a ("treewide: libgpiod v2 implementation")
Reported-by: 4fqr <4fqr@proton.me>
Tested-by: Vincent Fazio <vfazio@xes-inc.com>
Reviewed-by: Vincent Fazio <vfazio@xes-inc.com>
Link: https://patch.msgid.link/20260407-treewide-fixes-v1-2-66c9744a56a3@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
123 lines
2.8 KiB
C
123 lines
2.8 KiB
C
// SPDX-License-Identifier: LGPL-2.1-or-later
|
|
// SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
|
|
|
|
#include "internal.h"
|
|
|
|
typedef struct {
|
|
PyObject_HEAD;
|
|
struct gpiod_line_settings *settings;
|
|
} line_settings_object;
|
|
|
|
static int set_error(void)
|
|
{
|
|
Py_gpiod_SetErrFromErrno();
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
line_settings_init(line_settings_object *self, PyObject *args, PyObject *kwargs)
|
|
{
|
|
static char *kwlist[] = {
|
|
"direction",
|
|
"edge_detection",
|
|
"bias",
|
|
"drive",
|
|
"active_low",
|
|
"debounce_period",
|
|
"event_clock",
|
|
"output_value",
|
|
NULL
|
|
};
|
|
|
|
enum gpiod_line_clock event_clock;
|
|
enum gpiod_line_direction direction;
|
|
enum gpiod_line_value output_value;
|
|
unsigned long debounce_period;
|
|
enum gpiod_line_drive drive;
|
|
enum gpiod_line_edge edge;
|
|
enum gpiod_line_bias bias;
|
|
int ret, active_low;
|
|
|
|
ret = PyArg_ParseTupleAndKeywords(args, kwargs, "IIIIpkII", kwlist,
|
|
&direction, &edge, &bias, &drive, &active_low,
|
|
&debounce_period, &event_clock, &output_value);
|
|
if (!ret)
|
|
return -1;
|
|
|
|
self->settings = gpiod_line_settings_new();
|
|
if (!self->settings) {
|
|
Py_gpiod_SetErrFromErrno();
|
|
return -1;
|
|
}
|
|
|
|
ret = gpiod_line_settings_set_direction(self->settings, direction);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
ret = gpiod_line_settings_set_edge_detection(self->settings, edge);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
ret = gpiod_line_settings_set_bias(self->settings, bias);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
ret = gpiod_line_settings_set_drive(self->settings, drive);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
gpiod_line_settings_set_active_low(self->settings, active_low);
|
|
gpiod_line_settings_set_debounce_period_us(self->settings,
|
|
debounce_period);
|
|
|
|
ret = gpiod_line_settings_set_output_value(self->settings,
|
|
output_value);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
ret = gpiod_line_settings_set_event_clock(self->settings, event_clock);
|
|
if (ret)
|
|
return set_error();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void line_settings_finalize(line_settings_object *self)
|
|
{
|
|
if (self->settings)
|
|
gpiod_line_settings_free(self->settings);
|
|
}
|
|
|
|
PyTypeObject line_settings_type = {
|
|
PyVarObject_HEAD_INIT(NULL, 0)
|
|
.tp_name = "gpiod._ext.LineSettings",
|
|
.tp_basicsize = sizeof(line_settings_object),
|
|
.tp_flags = Py_TPFLAGS_DEFAULT,
|
|
.tp_new = PyType_GenericNew,
|
|
.tp_init = (initproc)line_settings_init,
|
|
.tp_finalize = (destructor)line_settings_finalize,
|
|
.tp_dealloc = (destructor)Py_gpiod_dealloc,
|
|
};
|
|
|
|
struct gpiod_line_settings *Py_gpiod_LineSettingsGetData(PyObject *obj)
|
|
{
|
|
line_settings_object *settings;
|
|
PyObject *type;
|
|
|
|
type = PyObject_Type(obj);
|
|
if (!type)
|
|
return NULL;
|
|
|
|
if ((PyTypeObject *)type != &line_settings_type) {
|
|
PyErr_SetString(PyExc_TypeError,
|
|
"not a gpiod._ext.LineSettings object");
|
|
Py_DECREF(type);
|
|
return NULL;
|
|
}
|
|
Py_DECREF(type);
|
|
|
|
settings = (line_settings_object *)obj;
|
|
|
|
return settings->settings;
|
|
}
|